Not possible to see full commit message for single commit push

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mconley, Assigned: gps)

Tracking

Details

(URL)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1134285 hid the [Reviews] and [Diff] links for pushes that have a single commit, since we felt that those links didn't make too much sense in the single-commit case.

However, this now makes it impossible to see the full commit message of a single commit push.

We might be able to mitigate this by setting the summary AND full description of a commit as the title attribute on the span showing the commit.
(Assignee)

Comment 1

3 years ago
I think the proper fix here is to inverse where the [Reviews] and [Diff] links go. Put them on the child review request, not the parent. And have code that marks the parent as ship-it if all the children are ship-it.

As it stands, if we start with a single commit, have a review, then add a new commit, reviews are attached to the parent instead of the child. That is wonky.

Updated

3 years ago
Priority: -- → P1
Not being able to see the full commit message is a bummer. I have a few commits I've pushed to review today where I wrote short novels' worth of commit messages, and they're not visible anywhere. :-/
(Assignee)

Comment 3

3 years ago
We'll back out bug 1134285 as part of bug 1055021.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1055021
(Assignee)

Comment 4

3 years ago
There are so many single patch reviews and I keep getting burned by this. I don't want to wait on bug 1055021. Let's just back out the original UX change and live with the pain until bug 1055021 lands.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Comment 5

3 years ago
Created attachment 8597532 [details]
MozReview Request: bz://1141588/gps

/r/7669 - mozreview: don't hide links to child reviews when there is a single review (bug 1141588)

Pull down this commit:

hg pull -r c6c91dc07eb08ab6a40638292c37897a1b421e3f https://reviewboard-hg.mozilla.org/version-control-tools/
Attachment #8597532 - Flags: review?(smacleod)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Not being able to see the full commit message is a bummer. I have a few
> commits I've pushed to review today where I wrote short novels' worth of
> commit messages, and they're not visible anywhere. :-/

They are visible if you click the link to the child review from BMO and that entry point has the same problem that I was trying to get rid of in bug 1134285. i.e. Since the BMO integration landed people are getting burned by the problem that bug 1134285 was trying to fix if they click on a child review in the BMO table.

Having people constantly complain that Ship It integration with BMO is broken is very annoying and is reducing developers' trust in mozreview so we should get bug 1055021 solved soon.
Assignee: nobody → gps
Status: REOPENED → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All

Comment 7

3 years ago
Hopefully no more than another week or so before bug 1055021 is done.  It's already gone through a couple reviews, and I have the BMO conversion script nearly done.
Comment on attachment 8597532 [details]
MozReview Request: bz://1141588/gps

https://reviewboard.mozilla.org/r/7667/#review6493

Ship It!
Attachment #8597532 - Flags: review?(smacleod) → review+
(Assignee)

Comment 9

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1323274cc924
(Assignee)

Comment 10

3 years ago
This got deployed to prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

3 years ago
Comment on attachment 8597532 [details]
MozReview Request: bz://1141588/gps
Attachment #8597532 - Attachment is obsolete: true
Attachment #8619719 - Flags: review+
(Assignee)

Comment 12

3 years ago
Created attachment 8619719 [details]
MozReview Request: mozreview: don't hide links to child reviews when there is a single review (bug 1141588)
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.