1141590 - Create mozilla-b2g37_v2_2 branched versions of marionette-client and consumer packages

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

+++ This bug was initially created as a clone of Bug #1128909 +++

Continuing on from bug 1128909 we need to create branched versions for the mozilla-b2g37_v2_2 release branch.

This means creating:
* marionette_client-mozilla-b2g37_v2_2
* gaiatest-v2.2
* b2gpopulate-v2.2
* b2gperf-v2.2

Given that these changes will need to land in quick succession, let's take care of them all in this single bug.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Create branched version of Marionette client for mozilla-b2g37_v2_2

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] davehunt:bug1141590 > mozilla-b2g:v2.2

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8575364 [details] [diff] [review]
Create branched version of Marionette client for mozilla-b2g37_v2_2

Review of attachment 8575364 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 4

[bhavana bajaj [:bajaj]]

Dave,

Taipei QA started hitting this In today's v2.2 smoketest run. They noticed there were many test cases failed with marionette javascript exception error.
Has anyone seen this error before? 
Javascript Error:
File "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.8.6-py2.7.egg/marionette/marionette.py", line 687, in _handle_error
raise errors.JavascriptException(message=message, status=status, stacktrace=stacktrace)
JavascriptException: JavascriptException: Element has not been seen before. Id given was [object Object]

Could this be related to any recent updates as we weren't hitting this last week.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to bhavana bajaj [:bajaj] from comment #4)
> Taipei QA started hitting this In today's v2.2 smoketest run. They noticed
> there were many test cases failed with marionette javascript exception error.
> Has anyone seen this error before? 
> Javascript Error:
> File
> "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/
> python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/
> marionette_client-0.8.6-py2.7.egg/marionette/marionette.py", line 687, in
> _handle_error
> raise errors.JavascriptException(message=message, status=status,
> stacktrace=stacktrace)
> JavascriptException: JavascriptException: Element has not been seen before.
> Id given was [object Object]

Please raise this as a separate bug.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4340d8ce6d0f
https://github.com/mozilla-b2g/gaia/commit/51959bfe85815ec13a677d4745af40272044317d

Once Treeherder reports everything is fine with the two commits I'll release new packages to PyPI.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Except now you're burning desktop tests because they aren't on PyPI.
https://treeherder.mozilla.org/logviewer.html#?job_id=63896&repo=mozilla-b2g37_v2_2

Also, tree rules say that you're supposed to be watching your pushes...

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out because the desktop bustage is blocking me from getting a lot of other uplifts done. Please be more considerate of others in the future and respect the tree rules.

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a509ec856b0c
https://github.com/mozilla-b2g/gaia/commit/2786a5b4aae1ee5155cd91f569250d8e458ba6d8

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> Also, tree rules say that you're supposed to be watching your pushes...

Please do not accuse me of something without full facts. I was watching my pushes whilst away from my desk, and returned to my desk promptly. I understand that you had no way of knowing this, but that doesn't mean you're right to make these accusations. I am sorry for causing bustage - you must realise this was unintentional. Attacking me for doing so is unfair and not going to help me to learn how to avoid this in the future.

Previous patches of this kind have had issues, and I was anticipating them. What I hadn't anticipated was that the web platform tests are running on this branch and appear to depend on a python package that's depending on marionette-client, preventing me from creating a branched package name.

James: Could you advise here? We need a v2.2 compatible version of marionette-client to serve the Gaia v2.2 function and performance tests.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Per our chat on IRC, a "Hey, I'm pushing this and will be checking back in later" ping on IRC would have gone a long way. Especially when, like you said, we've had issues like these in the past. I have no indication that you had any intent of coming back today based on all information in front of me.

Comment 11

[James Graham [:jgraham]]

fxos_appgen isn't actually a requirement anymore (unless you are running on B2G) and I think it should be safe to remove the line from mozharness that tries to install it.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The patch on bug 1143634 has landed but I'm not clear on whether anything else needs to happen for it to be used by try, or if it needs uplifting to v2.2. Ryan: Could you advise or point me in the direction of someone that can help?

I've triggered a try run with this patch again, just in case there's nothing more to do here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=955c453add2d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

The in-tree mozharness.json pointer still needs to be updated once your change is merged to production.

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Create branched version of Marionette client for mozilla-b2g37_v2_2

New version of the patch includes an update to the mozharness.json pointer.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=102d056a69b2

I'm expecting web platform tests to pass now, but the Gaia integration tests (Python) to fail due to the package rename. When we re-land this we'll update Gaia at the same time.

Comment 15

[Dave Hunt [:davehunt] [he/him] ⌚BST]

RyanVM: Could you take a look over the try results and let me know if you have any concerns? I don't see any Gip results, have these been disabled?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

There were no B2G desktop builds at all on that push. Probably lost in the Taskcluster switch :(

Nothing stands out as obviously broken with that run, so I think push and pray is the only real option here.

Comment 17

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Relanded as:
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/81681b374299
https://github.com/mozilla-b2g/gaia/commit/14888a2a9ad04b6f7f99db05d343836fc4b84538

I'm expecting Gip to fail on mozilla-b2g37_v2_2 until the gaia change is picked up. I'll be around to watch the results.

Comment 18

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Released as:
https://pypi.python.org/pypi/marionette_client-mozilla-b2g37_v2_2/0.1
https://pypi.python.org/pypi/gaiatest-v2.2/0.1

Comment 19

[Dave Hunt [:davehunt] [he/him] ⌚BST]

b2gpopulate updated in:
https://github.com/mozilla/b2gpopulate/commit/db7932b43c6250588838f3902609594ac67619be

Released as:
https://pypi.python.org/pypi/b2gpopulate-v2.2/0.1

Tagged as:
https://github.com/mozilla/b2gpopulate/releases/tag/v2.2-0.1

Comment 20

[Dave Hunt [:davehunt] [he/him] ⌚BST]

b2gperf updated in:
https://github.com/mozilla/b2gperf/commit/34f273d5bbd3fac2d18403a58c03ee54df19b798

Released as:
https://pypi.python.org/pypi/b2gperf-v2.2/0.1

Tagged as:
https://github.com/mozilla/b2gperf/releases/tag/v2.2-0.1