1141598 - Reader mode should open full screen

Status: RESOLVED WONTFIX

(Firefox for iOS :: Reader View, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

When you enter reader mode, the page should go full screen. There are two scenarios:

When pressing the Reader Mode button in the location bar, the browser chrome goes away and the page changes to reader mode.

When opening a reader mode link from the Reading List Panel, the interstitial (blank atm) should show first while loading the page, and then when loading is done, we hide the browser chrome.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/207

This patch hides the browser chrome when you enter reader view via either the reader view button or by opening a link from the reading list panel.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8575353 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/207

We don't do this on Android -- why is it different on iOS?

r=me assuming UX approves.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Reopening because we regressed on this.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Robin, I reopened this because we regressed on this bug due to changes in the way we implement the toolbars. But now I see Brian's comment that we don't actually open in full screen on Android. Just want to check with you if we still want to do this on iOS then.

Comment 5

[Robin Andersen [:tecgirl]]

(In reply to Stefan Arentz [:st3fan] from comment #4)
> Robin, I reopened this because we regressed on this bug due to changes in
> the way we implement the toolbars. But now I see Brian's comment that we
> don't actually open in full screen on Android. Just want to check with you
> if we still want to do this on iOS then.

The current interaction is fine. Thanks!