1141642 - Firefox fails to build on PPC64: image_operations.h:32:26: fatal error: skia/SkTypes.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Gustavo Luiz Duarte]

Building Firefox (mozilla-central) on PPC64 fails with the following error messages:

 2:26.59 In file included from /home/buildbot/buildbot/slave/runtests/build/image/src/Downscaler.cpp:12:0,
 2:26.59                  from /home/buildbot/buildbot/slave/runtests/build/obj-powerpc64-unknown-linux-gnu/image/src/Unified_cpp_image_src0.cpp:29:
 2:26.59 /home/buildbot/buildbot/slave/runtests/build/gfx/2d/image_operations.h:32:26: fatal error: skia/SkTypes.h: No such file or directory


For the full build log see: http://mozillaproject.osuosl.org:8010/builders/runtests/builds/2684/steps/shell/logs/stdio

Comment 1

[Steve Singer (:stevensn)]

Attachment: bug_114164.diff

This patch fixes the error by not building Downscaler.cpp on non-skia builds Downscaler.h already has a stub for non-skia builds.

This patch also includes a fix for a compile time error on the non-skia code path in the Compositor code.

Comment 2

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b06115bcb01

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8268d3740f9d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8268d3740f9d

Comment 5

[Steve Singer (:stevensn)]

Comment on attachment 8594421 [details] [diff] [review]
bug_114164.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1045929
[User impact if declined]: disable skia builds won't compile (many tier3 platforms won't build with skia enabled)
[Describe test coverage new/current, TreeHerder]: Tested on m-c
[Risks and why]: low risk, these changes are NPOTB-tier1
[String/UUID change made/needed]:

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8594421 [details] [diff] [review]
bug_114164.diff

Approved for aurora uplift since this looks stable on m-c.

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Steve, just curious - do we define tier 1, 2, 3 platforms somewhere? Thanks.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Nevermind, just found it: https://developer.mozilla.org/en-US/docs/Supported_build_configurations

Comment 9

[Ryan VanderMeulen [:RyanVM]]

checkin-needed isn't necessary on uplifts

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5aa451309199

Comment 11

[Landry Breuil (:gaston)]

Fwiw, will probably also need backport to beta - testing that the patch backported there fixes 38.0b9.

Comment 12

[Landry Breuil (:gaston)]

Comment on attachment 8594421 [details] [diff] [review]
bug_114164.diff

38.0b8 built fine on OpenBSD/powerpc with this backported, so would be nice to uplift there (and to m-r too!)

Approval Request Comment
[Feature/regressing bug #]: Bug 1045929
[User impact if declined]: disable skia builds won't compile (many tier3 platforms won't build with skia enabled)
[Describe test coverage new/current, TreeHerder]: Tested on m-c & m-a
[Risks and why]: low risk, these changes are NPOTB-tier1
[String/UUID change made/needed]: none

Comment 13

[Landry Breuil (:gaston)]

Cameron, did you hit this for tenfourfox or is skia enabled/fixed there ?

Comment 14

[Cameron Kaiser [:spectre]]

I'm sure I *will* hit it -- I haven't finished patching up 38ESR yet (Master's programs really suck away your hacking time). ETA is to jump from 31 to 38 around 38.0.2. If the existing patches I have don't fix this, I will incorporate yours into my changesets if this patch is not uplifted.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8594421 [details] [diff] [review]
bug_114164.diff

If this lands before Sunday, it will make it in 38RC. Otherwise, it will have to wait for ESR.

Comment 16

[Landry Breuil (:gaston)]

https://hg.mozilla.org/releases/mozilla-release/rev/538fd67bb637

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/538fd67bb637

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/538fd67bb637