Closed
Bug 1141642
Opened 9 years ago
Closed 9 years ago
Firefox fails to build on PPC64: image_operations.h:32:26: fatal error: skia/SkTypes.h: No such file or directory
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: gustavold, Assigned: stevensn)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
3.39 KB,
patch
|
jrmuizel
:
review+
lizzard
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Building Firefox (mozilla-central) on PPC64 fails with the following error messages: 2:26.59 In file included from /home/buildbot/buildbot/slave/runtests/build/image/src/Downscaler.cpp:12:0, 2:26.59 from /home/buildbot/buildbot/slave/runtests/build/obj-powerpc64-unknown-linux-gnu/image/src/Unified_cpp_image_src0.cpp:29: 2:26.59 /home/buildbot/buildbot/slave/runtests/build/gfx/2d/image_operations.h:32:26: fatal error: skia/SkTypes.h: No such file or directory For the full build log see: http://mozillaproject.osuosl.org:8010/builders/runtests/builds/2684/steps/shell/logs/stdio
Updated•9 years ago
|
Severity: blocker → normal
Whiteboard: [gfx-noted]
Assignee | ||
Comment 1•9 years ago
|
||
This patch fixes the error by not building Downscaler.cpp on non-skia builds Downscaler.h already has a stub for non-skia builds. This patch also includes a fix for a compile time error on the non-skia code path in the Compositor code.
Attachment #8594421 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b06115bcb01
Updated•9 years ago
|
Attachment #8594421 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8268d3740f9d
Assignee: nobody → steve
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8268d3740f9d
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Updated•9 years ago
|
status-firefox39:
--- → affected
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8594421 [details] [diff] [review] bug_114164.diff Approval Request Comment [Feature/regressing bug #]: Bug 1045929 [User impact if declined]: disable skia builds won't compile (many tier3 platforms won't build with skia enabled) [Describe test coverage new/current, TreeHerder]: Tested on m-c [Risks and why]: low risk, these changes are NPOTB-tier1 [String/UUID change made/needed]:
Attachment #8594421 -
Flags: approval-mozilla-aurora?
Comment on attachment 8594421 [details] [diff] [review] bug_114164.diff Approved for aurora uplift since this looks stable on m-c.
Attachment #8594421 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Steve, just curious - do we define tier 1, 2, 3 platforms somewhere? Thanks.
Flags: needinfo?(steve)
Nevermind, just found it: https://developer.mozilla.org/en-US/docs/Supported_build_configurations
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(steve)
Keywords: checkin-needed
Comment 11•9 years ago
|
||
Fwiw, will probably also need backport to beta - testing that the patch backported there fixes 38.0b9.
status-firefox38:
--- → affected
status-firefox38.0.5:
--- → affected
Comment 12•9 years ago
|
||
Comment on attachment 8594421 [details] [diff] [review] bug_114164.diff 38.0b8 built fine on OpenBSD/powerpc with this backported, so would be nice to uplift there (and to m-r too!) Approval Request Comment [Feature/regressing bug #]: Bug 1045929 [User impact if declined]: disable skia builds won't compile (many tier3 platforms won't build with skia enabled) [Describe test coverage new/current, TreeHerder]: Tested on m-c & m-a [Risks and why]: low risk, these changes are NPOTB-tier1 [String/UUID change made/needed]: none
Attachment #8594421 -
Flags: approval-mozilla-release?
Attachment #8594421 -
Flags: approval-mozilla-beta?
Comment 13•9 years ago
|
||
Cameron, did you hit this for tenfourfox or is skia enabled/fixed there ?
Flags: needinfo?(spectre)
Comment 14•9 years ago
|
||
I'm sure I *will* hit it -- I haven't finished patching up 38ESR yet (Master's programs really suck away your hacking time). ETA is to jump from 31 to 38 around 38.0.2. If the existing patches I have don't fix this, I will incorporate yours into my changesets if this patch is not uplifted.
Flags: needinfo?(spectre)
Comment 15•9 years ago
|
||
Comment on attachment 8594421 [details] [diff] [review] bug_114164.diff If this lands before Sunday, it will make it in 38RC. Otherwise, it will have to wait for ESR.
Attachment #8594421 -
Flags: approval-mozilla-release?
Attachment #8594421 -
Flags: approval-mozilla-release+
Attachment #8594421 -
Flags: approval-mozilla-beta?
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/538fd67bb637
status-firefox-esr38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•