Closed Bug 1141666 Opened 5 years ago Closed 5 years ago

[Hacker Marketplace] App icon improvements

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Unassigned)

References

()

Details

(Whiteboard: [spark])

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1133976#c6.

This bug aims to fix:
> 1. Homescreen: On the homescreen we should use the actual homescreen app
> icons (i.e camera, dialer) and default to the grey rocket ship icon if none
> applies (see spec).
> 
> 8. The app/add-on icons from Hackerplace should match the app/add-on icons
> on homescreen once the app is installed.
Comment on attachment 8575464 [details] [review]
[PR] allow apps to specify icon url

Looks generally good, but I left some comments on the PR for potential future changes.
Attachment #8575464 - Flags: review?(dsherk) → review+
master: https://github.com/fxos/directory/commit/d5d1d90db81e78838a933928642489ac2eb8a059
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.