bugzilla.mozilla.org will be intermittently unavailable on Saturday, March 24th, from 16:00 until 20:00 UTC.

Update package.json mail-fakeservers to 0.0.36



Firefox OS
3 years ago
21 days ago


(Reporter: jrburke, Unassigned)


Firefox Tracking Flags

(Not tracked)



(3 attachments)



3 years ago
The email marionette tests use mail-fakeservers in the tests, and 0.0.24, the version in gaia's package.json, no longer works with master gaia/gecko code.

The tests are not enabled for automation, but used by some email devs locally to confirm that front end changes still pass the tests.

The fix was to update to version 0.0.35, so this ticket tracks updating the gaia-node-modules and gaia repos with the change.
Created attachment 8575471 [details] [review]
[gaia-node-modules] jrburke:bug1141699-test-mail-fakeservers-update > mozilla-b2g:master

Comment 2

3 years ago
Comment on attachment 8575471 [details] [review]
[gaia-node-modules] jrburke:bug1141699-test-mail-fakeservers-update > mozilla-b2g:master

Asking asuth for review since this is a package change localized to email and its backend fakeserver stuff.

Side note for next time a new version of the mail-fakservers package is pushed to npm, might be to remove some of the ~ files.
Attachment #8575471 - Flags: review?(bugmail)
Comment on attachment 8575471 [details] [review]
[gaia-node-modules] jrburke:bug1141699-test-mail-fakeservers-update > mozilla-b2g:master

Hm, yeah, there's all kinds of garbage temporary files in there.  I see sockit-to-me has an .npmignore, so I guess that's the thing to do.  (And/or improve our .gitignore.)

Note that the nested inclusion of sockit-to-me might be concerning because of the v0.12 update needed for sockit-to-me (bug 1136258 created 0.3.0).  We might want to update mail-fakeservers to reference the new version?  You have push authority for the npm package, so rs=asuth on bumping the revision and our sockit-to-me dep if you want, etc. etc.
Attachment #8575471 - Flags: review?(bugmail) → review+

Comment 4

3 years ago
Merged in gaia-node-modules:

Used 0.0.36, which is just 0.0.35 but without the ~ files and no sockit-to-me as a dependency, it is a devDependency now in mail-fakeservers.

Will create the gaia pull request and carry review over to that one, and will use autolander to land it via checkin-needed once gaia-try pass confirms OK.


3 years ago
Summary: Update package.json mail-fakeservers to 0.0.35 → Update package.json mail-fakeservers to 0.0.36
Created attachment 8575583 [details] [review]
[gaia] jrburke:bug1141699-test-mail-fakeservers-update > mozilla-b2g:master

Comment 6

3 years ago
Comment on attachment 8575583 [details] [review]
[gaia] jrburke:bug1141699-test-mail-fakeservers-update > mozilla-b2g:master

Carrying r=asuth over, and will land this immediately since bug 1129445 picked up the 0.0.36 package contents change (it landed on gaia-node-modules after the merge for this bug on that repo), so just need to make sure the gaia package.json is kept in sync.
Attachment #8575583 - Flags: review+

Comment 7

3 years ago
In gaia master:
Last Resolved: 3 years ago
Resolution: --- → FIXED
Created attachment 8575605 [details] [review]
[gaia] jrburke:bug1141699-revert > mozilla-b2g:master

Comment 9

3 years ago
This was reverted here:

it does not fix the problem and made it worse, since socket-to-me is used in mail-fakeserver, and this change messed it somehow, the error when running one of the email gaia marionettejs tests was:

Error: Cannot find module 'sockit-to-me'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/jr/git/gaia-jrburke/node_modules/mail-fakeservers/lib/sync_control_request.js:2:18)
    at Module._compile (module.js:456:26)

So reopening, and resetting for a while. I'll go back and do a mail-fakeserver 0.0.37 to fix the damage I did and then walk away from this for a while.
Assignee: jrburke → nobody
Resolution: FIXED → ---

Comment 10

21 days ago
Firefox OS is not being worked on
Last Resolved: 3 years ago21 days ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.