114171 - [Win Widget] leak nsNativeDragTarget

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We leak an nsNativeDragTarget somehow -- it might be that we're calling system 
functions that cause it to be |AddRef|ed and then not |Release|d.  I might get 
a chance to look into this some more.  If not, I at least have some logging 
code.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: refcount logging

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: refcount balance tree

2 objects are leaked.  The trees look pretty much the same.

Comment 3

[jag (Peter Annema)]

Comment on attachment 60919 [details] [diff] [review]
refcount logging

r=/sr=jag

Comment 4

[rods (gone)]

r=rods

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I checked in the logging.  Since I don't have access to a Windows machine
anymore, giving this to rods, although it should probably be low-priority and
might even be a Windows bug/feature.

Comment 6

[rods (gone)]

Which part did you check in?

Do I need to check in these windows files?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's no fix.  I checked in the patch in attachment 60919 [details] [diff] [review], but that patch just
adds logging so that one can see the problem better.

Comment 8

[Kevin McCluskey (gone)]

Moving to Moz1.1. Engineers are overloaded with higher priority bugs.

Comment 9

[Eli Friedman]

Attachment: Patch

Pretty straightforward; I don't know who's the best person to ask for review in Windows widget code these days.

Justification of the patch: there are two places we set mWnd to null; one is where this patch is, and the other one has an EnableDragDrop(PR_FALSE) call already.

Note that this is basically the only consistent contributor to Rlk on Windows.

Comment 10

[Eli Friedman]

Comment on attachment 274112 [details] [diff] [review]
Patch

Fix for a minor leak, low-risk (the extra call does nothing if it isn't needed).

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 274112 [details] [diff] [review]
Patch

a19=dbaron

Comment 12

[Eli Friedman]

Checked in.