Closed Bug 114171 Opened 20 years ago Closed 14 years ago

[Win Widget] leak nsNativeDragTarget

Categories

(Core :: Widget: Win32, defect, P2)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: dbaron, Assigned: sharparrow1)

Details

(Keywords: memory-leak)

Attachments

(3 files)

We leak an nsNativeDragTarget somehow -- it might be that we're calling system 
functions that cause it to be |AddRef|ed and then not |Release|d.  I might get 
a chance to look into this some more.  If not, I at least have some logging 
code.
Attached patch refcount loggingSplinter Review
Attached file refcount balance tree
2 objects are leaked.  The trees look pretty much the same.
Keywords: mlk
Comment on attachment 60919 [details] [diff] [review]
refcount logging

r=/sr=jag
Attachment #60919 - Flags: superreview+
Status: NEW → ASSIGNED
r=rods
I checked in the logging.  Since I don't have access to a Windows machine
anymore, giving this to rods, although it should probably be low-priority and
might even be a Windows bug/feature.
Assignee: dbaron → rods
Severity: normal → minor
Status: ASSIGNED → NEW
Which part did you check in?

Do I need to check in these windows files?
Status: NEW → ASSIGNED
Summary: [Win Widget] leak nsNativeDragTarget → [FIX][Win Widget] leak nsNativeDragTarget
Target Milestone: --- → mozilla0.9.8
There's no fix.  I checked in the patch in attachment 60919 [details] [diff] [review], but that patch just
adds logging so that one can see the problem better.
Summary: [FIX][Win Widget] leak nsNativeDragTarget → [Win Widget] leak nsNativeDragTarget
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
Moving to Moz1.1. Engineers are overloaded with higher priority bugs.
Target Milestone: mozilla1.0 → mozilla1.1
Priority: -- → P2
Target Milestone: mozilla1.1 → Future
Attached patch PatchSplinter Review
Pretty straightforward; I don't know who's the best person to ask for review in Windows widget code these days.

Justification of the patch: there are two places we set mWnd to null; one is where this patch is, and the other one has an EnableDragDrop(PR_FALSE) call already.

Note that this is basically the only consistent contributor to Rlk on Windows.
Assignee: rods → sharparrow1
Attachment #274112 - Flags: review?(cbiesinger)
Attachment #274112 - Flags: review?(cbiesinger) → review+
Attachment #274112 - Flags: superreview?(cbiesinger)
Attachment #274112 - Flags: superreview?(cbiesinger) → superreview+
Comment on attachment 274112 [details] [diff] [review]
Patch

Fix for a minor leak, low-risk (the extra call does nothing if it isn't needed).
Attachment #274112 - Flags: approval1.9?
Component: XP Toolkit/Widgets → Widget: Win32
QA Contact: jrgmorrison → win32
Comment on attachment 274112 [details] [diff] [review]
Patch

a19=dbaron
Attachment #274112 - Flags: approval1.9? → approval1.9+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.