1141716 - Use .SVG images for empty state of about:pages

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

> It'd be great to try using svg, because we've talked about doing that but
> haven't done so yet. We don't use one large resource that can get scaled
> down because (I assume) it's more memory and CPU intensive for smaller,
> likely less powerful devices. I wonder if SVG has those setbacks? Or perhaps
> they're just larger files that we have to include.

This is something we talked about in bug 1101746, filing this bug to track that work in an effort to close the other and get things moving. Also, Chenxia brought up some issues that we might run into so I thought we should split up this work.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_key_emptypage_SVG.svg

Here's the SVG, Ally. I made it slightly bigger than the spec, but none of the margins change. 

I also went with the Key here to keep it consistent with the door hanger and toolbar icon. I'll attach .PNG versions in the other bug just in case.

Comment 2

[Allison Naaktgeboren :ally]

relevant https://etherpad.mozilla.org/svg-guidelines

Comment 3

[Scott Wu [:scottwu]]

Has this bug been resolved already? I see that the about:logins page already uses the SVG icon.

Or are there any other icons that need to be replaced? Thanks!

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I'm not too sure actually. Ally (who was working on this) is no longer with Mozilla so I'm not able to confirm. If you're saying we already do this then this can be closed :)

Comment 5

[:Margaret Leibovic]

I think we can close this out.