1141782 - Use PageMetadata.jsm in ReaderMode

Status: RESOLVED INVALID

(Toolkit :: Reader Mode, defect, P5)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Readaility has it's own page metadata technique, but it's not nearly as comprehensive as PageMetadata.jsm (bug 1131911). And that gap will grow over time, as we add to PageMetadata.jsm and coalesce the data from various formats.

So I think we should replace ReaderMode's own metadata handling with PageMetadata.jsm

Comment 1

[:Margaret Leibovic]

Probably what we should do here is move the metadata logic out of Readability.js itself, and instead use PageMetadata.jsm in ReaderMode.jsm to add the meta data to the article after we get it.

In fact, this could help solve the problem of getting meta data when Readability.js fails.

I don't think this is necessary for v1 of this feature, but this would definitely help the Android reading list show better data.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to :Margaret Leibovic from comment #1)
> I don't think this is necessary for v1 of this feature, but this would
> definitely help the Android reading list show better data.

It would also greatly help desktop - we'd get more consistent data being synced from Android, including the feature image which AFAIK Android doesn't currently support (desktop uses this in the sidebar).

Comment 3

[Justin Dolske [:Dolske]]

Huh. Thought we already did this, but we don't!

Should really do this, but in lieu of an actual impact to users (and that we've not been running across this being a problem so far), P4.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:auswerk-makes-stuff-better > mozilla-b2g:master

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8595058 [details] [review]
[gaia] mozilla-b2g:auswerk-makes-stuff-better > mozilla-b2g:master

It appears that someone specified the wrong bug number in a gaia commit. Sorry about the noise here.

Comment 6

[:Gijs (he/him)]

Pagemetadata.jsm got removed, so I don't think this is valid anymore.