Closed Bug 1141782 Opened 5 years ago Closed 7 months ago

Use PageMetadata.jsm in ReaderMode

Categories

(Toolkit :: Reader Mode, defect, P5)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: Unfocused, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reader-mode-firefox-integration])

Attachments

(1 obsolete file)

Readaility has it's own page metadata technique, but it's not nearly as comprehensive as PageMetadata.jsm (bug 1131911). And that gap will grow over time, as we add to PageMetadata.jsm and coalesce the data from various formats.

So I think we should replace ReaderMode's own metadata handling with PageMetadata.jsm
Probably what we should do here is move the metadata logic out of Readability.js itself, and instead use PageMetadata.jsm in ReaderMode.jsm to add the meta data to the article after we get it.

In fact, this could help solve the problem of getting meta data when Readability.js fails.

I don't think this is necessary for v1 of this feature, but this would definitely help the Android reading list show better data.
(In reply to :Margaret Leibovic from comment #1)
> I don't think this is necessary for v1 of this feature, but this would
> definitely help the Android reading list show better data.

It would also greatly help desktop - we'd get more consistent data being synced from Android, including the feature image which AFAIK Android doesn't currently support (desktop uses this in the sidebar).
Huh. Thought we already did this, but we don't!

Should really do this, but in lieu of an actual impact to users (and that we've not been running across this being a problem so far), P4.
Priority: -- → P4
Comment on attachment 8595058 [details] [review]
[gaia] mozilla-b2g:auswerk-makes-stuff-better > mozilla-b2g:master

It appears that someone specified the wrong bug number in a gaia commit. Sorry about the noise here.
Attachment #8595058 - Attachment is obsolete: true
Priority: P4 → P5
See Also: → 923806
Depends on: 1155014
Whiteboard: [reader-mode-firefox-integration]
See Also: → 1503674

Pagemetadata.jsm got removed, so I don't think this is valid anymore.

Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.