If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't implicitly dispatch a runnable to the main thread in RasterImage::StartDecoding

RESOLVED FIXED in Firefox 39

Status

()

Core
ImageLib
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
After bug 1139225, there's no longer a reason for RasterImage::StartDecoding to work implicitly off-main-thread. We should remove the implicit runnable dispatch code, so we don't encourage people to call this method off-main-thread.

Note that if anyone does do so, we'll know, because there's an assertion in RasterImage::RequestDecodeForSize (which is used to implement RasterImage::StartDecoding) which will fire if it runs off-main-thread. So we don't need a new assertion here.
(Assignee)

Comment 1

3 years ago
Created attachment 8575634 [details] [diff] [review]
Don't implicitly dispatch a runnable to the main thread in RasterImage::StartDecoding

Here's the patch.
Attachment #8575634 - Flags: review?(amarchesini)
(Assignee)

Comment 2

3 years ago
Whoops, this got mixed in with a large stack of commits I just pushed to inbound by mistake. I thought this had already been r+'d.

bb86ca5e5552	Seth Fowler — Bug 1141819 - Don't implicitly dispatch a runnable to the main thread in RasterImage::StartDecoding. r=baku

I don't want to back out because doing so will require another round of testing.

Andrea, if you have time, could you review this soon? I'll push a followup with any changes you request. If you don't have time, please let me know and I'll ask someone else to review.
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/bb86ca5e5552
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Depends on: 1150127
Comment on attachment 8575634 [details] [diff] [review]
Don't implicitly dispatch a runnable to the main thread in RasterImage::StartDecoding

Review of attachment 8575634 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the explanation by email.
Attachment #8575634 - Flags: review?(amarchesini) → review+
Flags: needinfo?(amarchesini)
(Assignee)

Updated

3 years ago
No longer depends on: 1150127
You need to log in before you can comment on or make changes to this bug.