Trivial 'synchronizer' for client records

RESOLVED FIXED

Status

()

Firefox for iOS
Sync
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
This is a simple 'up-down' synchronizer: it fetches changed records and writes them into storage, and uploads a client record if needed. No synchronization per se.
(Assignee)

Updated

3 years ago
Blocks: 1141847
(Assignee)

Updated

3 years ago
Blocks: 1141849
(Assignee)

Updated

3 years ago
Blocks: 1104867
(Assignee)

Updated

3 years ago
Depends on: 1151970
(Assignee)

Comment 1

3 years ago
Attacking this and tabs together:

https://github.com/mozilla/firefox-ios/pull/330
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8591773 [details] [review]
Pull req.

There are some todos.

The caller into SyncAuthState needs to know the token server URI, so I hard-code prod. Suggestions welcome.

This only hooks into refresh. Each refresh will result in an i/c fetch.
Attachment #8591773 - Flags: review?(nalexander)
(Assignee)

Comment 3

3 years ago
Landed apart from the prod URI switchover.

https://github.com/mozilla/firefox-ios/commit/2824e8b62f83a2450b5735efd536f5141b807c81
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
No longer blocks: 1104867
(Assignee)

Updated

3 years ago
Blocks: 1154551
(Assignee)

Updated

3 years ago
Blocks: 1154553
Comment on attachment 8591773 [details] [review]
Pull req.

Reviewed on GH, IRC, and in person.
Attachment #8591773 - Flags: review?(nalexander) → review+
You need to log in before you can comment on or make changes to this bug.