[P2P Sharing] Refresh local app list when receiving `install` and `uninstall` events

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spark])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We should cache the app list to speed up retrieval. Right now, we:
a. Don't do any caching for network requests, so we have to re-get the whole app list on every request.
b. Don't refresh the local app list when an app is (un)installed.

We should refresh this cached app list and re-render the local apps when we receive `install` and `uninstall` events.
(Assignee)

Updated

4 years ago
Blocks: 1141866
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8575977 [details] [review]
Refresh local app list when receiving `install` and `uninstall` events.
Attachment #8575977 - Flags: review?(jdarcangelo)
Comment on attachment 8575977 [details] [review]
Refresh local app list when receiving `install` and `uninstall` events.

I only looked at the last 2 commits since the rest of the patch seems to have been based off of the other visual refinements patch. LGTM.
Attachment #8575977 - Flags: review?(jdarcangelo) → review+
(Assignee)

Comment 3

4 years ago
https://github.com/fxos/sharing/commit/f7fd1cdcacb9a0a2d58180d8bd4afc0bc3f320c8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
Component: Gaia → Gaia::P2P Sharing
You need to log in before you can comment on or make changes to this bug.