bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

[P2P Sharing] Ask the user to input a device name the first time the "Share My Apps" section is opened

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lightsaber])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We're currently defaulting to the device name, e.g. "Flame", but we should instead prompt the user to enter this.
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8580840 [details] [review]
Ask the user to input a device name the first time the "Share My Apps" section is opened.

This patch prevents the user from doing anything in the "Share My Apps" menu until they set a device name.
Attachment #8580840 - Flags: review?(jdarcangelo)
Comment on attachment 8580840 [details] [review]
Ask the user to input a device name the first time the "Share My Apps" section is opened.

I put a suggestion in the GH comments about dealing with `this.el.els`. It looks a little weird and I think my proposed solution might help make it look a little less clumsy.
Attachment #8580840 - Flags: review?(jdarcangelo) → review+
(Assignee)

Comment 3

3 years ago
Fixed suggestion in comment 2.
https://github.com/fxos/sharing/commit/d9d6e0d2383f0590eec2927ae3683df496877d99
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.