Closed
Bug 1141887
Opened 10 years ago
Closed 10 years ago
[Stingray] apply focus manager to app window related UIs
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
The previous patches had updated the system UIs to use focus manager to focus itself.
There are two parts in this issue:
1. apply focus manager to app window
2. check if there is any places calling HTMLDOMElement.focus() not inside of API of Focusable UI, the focus() function.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → im
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master
Hi Luke and Sung,
I had scanned and changed the whole smart-system to use focus manager. The change is complex. Please review this patch. Thanks.
Attachment #8575752 -
Flags: review?(suchiu)
Attachment #8575752 -
Flags: review?(lchang)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master
It's pretty good to me!
Attachment #8575752 -
Flags: review?(suchiu) → review+
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master
I've done review with a few nits. Please take a look. The rest looks great! Thanks.
Attachment #8575752 -
Flags: review?(lchang) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/77c27e22b05f8bc78aea65cf559b52ca89833c20
gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=60ff2433642e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•