[Stingray] apply focus manager to app window related UIs

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The previous patches had updated the system UIs to use focus manager to focus itself.

There are two parts in this issue:
1. apply focus manager to app window
2. check if there is any places calling HTMLDOMElement.focus() not inside of API of Focusable UI, the focus() function.
Assignee: nobody → im
Created attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master

Hi Luke and Sung,

I had scanned and changed the whole smart-system to use focus manager. The change is complex. Please review this patch. Thanks.
Attachment #8575752 - Flags: review?(suchiu)
Attachment #8575752 - Flags: review?(lchang)

Comment 3

4 years ago
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master

It's pretty good to me!
Attachment #8575752 - Flags: review?(suchiu) → review+
Comment on attachment 8575752 [details] [review]
[gaia] huchengtw-moz:bug-1141887-app-window-focus > mozilla-b2g:master

I've done review with a few nits. Please take a look. The rest looks great! Thanks.
Attachment #8575752 - Flags: review?(lchang) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/77c27e22b05f8bc78aea65cf559b52ca89833c20

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=60ff2433642e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.