1141976 - [Bluetooth] does not get detail while bt device connected with profile

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail]]

comparing with bluetooth.js, bluetooth_v2.js does not provide detail array during bluetoothprofileconnectionchange event

It's due to bluetooth_v2.js use the new dispatchEvent format, which does not contain provided dictionaries into 'detail' object by default.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1141976 > mozilla-b2g:master

Comment 2

[[e-mail]]

Comment on attachment 8575888 [details] [review]
[gaia] gasolin:issue-1141976 > mozilla-b2g:master

It should only efffect BTv2 because I changed to the syntax new event dispatch format, which does not attach properties into detail object

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8575888 [details] [review]
[gaia] gasolin:issue-1141976 > mozilla-b2g:master

The patch is okay for me. But there is no unit test for checking what dispatch event Bluetooth_v2 module has fired. The other nit is commit log in wrong format.

Comment 4

[[e-mail]]

Comment on attachment 8575888 [details] [review]
[gaia] gasolin:issue-1141976 > mozilla-b2g:master

test added to make sure the received event contain detail object.

Rename the commit to `wrap emit array within detail object to patible with old initCustomEvent format`

please kindly review it again :)

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 8575888 [details] [review]
[gaia] gasolin:issue-1141976 > mozilla-b2g:master

r+ without commit format nit, thanks.

Comment 6

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/e0b5b58321fe3549f57bf3f6eb4bb4601b1ce74c

thanks