Closed Bug 1141988 Opened 9 years ago Closed 9 years ago

Convert update-wizard ui module to Marionette

Categories

(Testing :: Firefox UI Tests, defect, P1)

Product:
Testing
Component:
Firefox UI Tests
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla39

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

github_pull_request.txt
53 bytes, text/x-github-pull-request
chmanchester
: review+
chmanchester
: feedback+
Details | Review 
We have to convert the update wizard ui module so we can handle incompatible addons and especially fallback updates.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/lib/ui/update-wizard.js
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
This is not a window but a dialog. So I will to get bug 1143020 fixed first.
Depends on: 1143020
Whiteboard: [blocked]
No longer depends on: 1143020
Priority: -- → P1
PR is up and Travis is passing for Linux and OS X. Chris, would be great if we can get this PR reviewed ASAP so I can finish up the update tests. Thanks.
Attachment #8578081 - Flags: review?(cmanchester)
Comment on attachment 8578081 [details] [review]
github_pull_request.txt

A couple of things in the PR.
Attachment #8578081 - Flags: review?(cmanchester) → feedback+
Comment on attachment 8578081 [details] [review]
github_pull_request.txt

PR has been updated for the feedback requests.
Attachment #8578081 - Flags: review?(cmanchester)
Whiteboard: [blocked]
Attachment #8578081 - Flags: review?(cmanchester) → review+
https://github.com/mozilla/firefox-ui-tests/commit/1173d06ca600e8ff1cacc7c91787be81dd37e87b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: