Closed Bug 1141991 Opened 6 years ago Closed 6 years ago

Account creation system does not auto-update port when changing SSL status using keyboard

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
normal

Tracking

(thunderbird38 fixed, thunderbird39 fixed)

RESOLVED FIXED
Thunderbird 39.0
Tracking Status
thunderbird38 --- fixed
thunderbird39 --- fixed

People

(Reporter: gerv, Assigned: aceman)

References

Details

Attachments

(1 file)

STR:

* Go through the process of creating a new account
* Do manual config
* Tab through the controls to the security control, which offers Autodetect or STARTTLS or SSL/TLS
* Change the value using the up and down arrow keys

Expected: port number updates, as it does when you select a new value using the mouse

Actual: port number does not update

Because the port number does not update, it will try SSL/TLS on the non-SSL port, and fail. The behaviour when using mouse and keyboard should be consistent.

Gerv
Yeah, right. Seems it is caused by attaching the port changing logic to the event of closing the popup (<menupopup onpopuphidden="gEmailConfigWizard.onChangedSSLIncoming()">), which probably does not happen when not opening the popup but using mouse.

We should hook it at <menulist oncommand=""> which is run when the selected value changes, whether by mouse or keyboard.
Assignee: nobody → acelists
OS: Linux → All
QA Contact: ben.bucksch
Hardware: x86 → All
Version: unspecified → Trunk
Attached patch patchSplinter Review
This could do it.
Attachment #8576260 - Flags: review?(mkmelin+mozilla)
Attachment #8576260 - Flags: feedback?(ben.bucksch)
I've also filed bug 1142224 for stuck focus inside the SMTP hostname menulist.
Depends on: 1142224
Comment on attachment 8576260 [details] [diff] [review]
patch

Review of attachment 8576260 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r=mkmelin
Attachment #8576260 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8576260 [details] [diff] [review]
patch

Looks good to me
Attachment #8576260 - Flags: feedback?(ben.bucksch) → feedback+
Thanks.
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/f1739bc5332c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Could someone please confirm that this also occurs in versions of TB prior to 39, so that we should take it in tb 38?
This probably existed since the Account wizard exists so it is not new.
You need to log in before you can comment on or make changes to this bug.