1141991 - Account creation system does not auto-update port when changing SSL status using keyboard

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Gervase Markham [:gerv]]

STR:

* Go through the process of creating a new account
* Do manual config
* Tab through the controls to the security control, which offers Autodetect or STARTTLS or SSL/TLS
* Change the value using the up and down arrow keys

Expected: port number updates, as it does when you select a new value using the mouse

Actual: port number does not update

Because the port number does not update, it will try SSL/TLS on the non-SSL port, and fail. The behaviour when using mouse and keyboard should be consistent.

Gerv

Comment 1

[:aceman]

Yeah, right. Seems it is caused by attaching the port changing logic to the event of closing the popup (<menupopup onpopuphidden="gEmailConfigWizard.onChangedSSLIncoming()">), which probably does not happen when not opening the popup but using mouse.

We should hook it at <menulist oncommand=""> which is run when the selected value changes, whether by mouse or keyboard.

Comment 2

[:aceman]

Attachment: patch

This could do it.

Comment 3

[:aceman]

I've also filed bug 1142224 for stuck focus inside the SMTP hostname menulist.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8576260 [details] [diff] [review]
patch

Review of attachment 8576260 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r=mkmelin

Comment 5

[Ben Bucksch (:BenB)]

Comment on attachment 8576260 [details] [diff] [review]
patch

Looks good to me

Comment 6

[:aceman]

Thanks.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

http://hg.mozilla.org/comm-central/rev/f1739bc5332c

Comment 8

[Kent James (:rkent)]

Could someone please confirm that this also occurs in versions of TB prior to 39, so that we should take it in tb 38?

Comment 9

[:aceman]

This probably existed since the Account wizard exists so it is not new.

Comment 10

[Kent James (:rkent)]

Comment on attachment 8576260 [details] [diff] [review]
patch

[Triage Comment] simple fix

https://hg.mozilla.org/releases/comm-aurora/rev/f7ff3d2c4596