Auto ack/nack in pulse-go library

NEW
Unassigned

Status

4 years ago
4 years ago

People

(Reporter: pmoore, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
PulseLibrary in taskcluster-client automatically acks/nacks. This was introduced here:
  * https://github.com/taskcluster/taskcluster-client/commit/a236d48b9907581dedcfa3e97fee6739336df847#diff-bdeec392e02b8fc5c8a9ac0b62f3b398R349

It would be good to introduce some auto-acking/nacking into the pulse go client, around here:
  * https://github.com/petemoore/pulse-go/blob/master/pulse/pulse.go#L291
What do you do at the moment?

IMO you should just let the handler return an error, if you want nack, and otherwise ack when handler returns.
You need to log in before you can comment on or make changes to this bug.