Closed
Bug 1142022
Opened 9 years ago
Closed 3 years ago
Auto ack/nack in pulse-go library
Categories
(Taskcluster :: UI, defect, P5)
Tracking
(Not tracked)
RESOLVED
MOVED
People
(Reporter: pmoore, Unassigned)
Details
PulseLibrary in taskcluster-client automatically acks/nacks. This was introduced here: * https://github.com/taskcluster/taskcluster-client/commit/a236d48b9907581dedcfa3e97fee6739336df847#diff-bdeec392e02b8fc5c8a9ac0b62f3b398R349 It would be good to introduce some auto-acking/nacking into the pulse go client, around here: * https://github.com/petemoore/pulse-go/blob/master/pulse/pulse.go#L291
Comment 1•9 years ago
|
||
What do you do at the moment? IMO you should just let the handler return an error, if you want nack, and otherwise ack when handler returns.
Comment 2•5 years ago
|
||
Pete, is this a good mentored bug? Is pulse-go still a going (sorry) concern?
Flags: needinfo?(pmoore)
Reporter | ||
Comment 3•5 years ago
|
||
Let's just make this a P5. There isn't currently anything in production that relies on the go pulse client, so it isn't so important. The workers don't interface directly with pulse.
Component: Pulse → UI and Tools
Flags: needinfo?(pmoore)
Priority: -- → P5
Product: Webtools → Taskcluster
Comment 4•5 years ago
|
||
For other languages, we're deprecating the idea of a pulse-specific library in favor of just using native AMQP libraries. Should we do the same with Go? In other words, deprecate use of pulse-go?
Comment 5•3 years ago
|
||
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → MOVED
You need to log in
before you can comment on or make changes to this bug.
Description
•