Closed Bug 1142045 Opened 8 years ago Closed 8 years ago

Clear History when Firefox closes in-content pref (sub)dialog throws error when opened: ReferenceError: onClearHistoryChanged is not defined

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Iteration:
39.2 - 23 Mar
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(1 file)

fix onClearHistoryChanged reference,
1.33 KB, patch
jaws
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
JavaScript error: chrome://browser/content/preferences/sanitize.js, line 13: ReferenceError: onClearHistoryChanged is not defined
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Summary: Clear History when Firefox closes in-content pref dialog throws error: ReferenceError: onClearHistoryChanged is not defined → Clear History when Firefox closes in-content pref (sub)dialog throws error when opened: ReferenceError: onClearHistoryChanged is not defined
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1128177
Status: NEW → ASSIGNED
Iteration: --- → 39.2 - 23 Mar
Points: 2 → 1
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Can't believe I missed this in review. :-\
Attachment #8576330 - Flags: review?(jaws)
status-firefox38: --- → affected
status-firefox39: --- → affected
Flags: qe-verify+ → qe-verify-
Comment on attachment 8576330 [details] [diff] [review]
fix onClearHistoryChanged reference,

Review of attachment 8576330 [details] [diff] [review]:
-----------------------------------------------------------------

Can't believe I missed this in implementation :/
Attachment #8576330 - Flags: review?(jaws) → review+
Comment on attachment 8576330 [details] [diff] [review]
fix onClearHistoryChanged reference,

Approval Request Comment
[Feature/regressing bug #]: bug 1128177
[User impact if declined]: non-working clear history settings dialog
[Describe test coverage new/current, TreeHerder]: nope, clearly :-\
[Risks and why]: none
[String/UUID change made/needed]: nope
Attachment #8576330 - Flags: approval-mozilla-aurora?
remote:   https://hg.mozilla.org/integration/fx-team/rev/3dddfc20066e
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3dddfc20066e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Attachment #8576330 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.