1142080 - Apps are badly resize when toggling the orientation on b2g desktop

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Alexandre Poirot [:ochameau]]

It looks like since bug 1107759, the apps are badly resized when going into landscape and the app doesn't support landscape. We only see half of the app and a black area.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

I don't know what happened in bug 1107759 and when we regressed so badly,
but here is a fix and I cleanup up the related code a bit.

It also fix support of default orientation different than portrait (cc:janx).

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e14aadd9bf0

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8576028 [details] [diff] [review]
patch v1

Review of attachment 8576028 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: b2g/chrome/content/screen.js
@@ +198,1 @@
>      }

nit: let controlsHeight = controls ? controls.getBCR().height : 0

::: b2g/chrome/content/shell.css
@@ +20,3 @@
>    border: none;
> +  width: 100%;
> +  height: 100%;

that's a no-op change, right? if so, don't do it ;)

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Fixed the nits.

Comment 5

[Alexandre Poirot [:ochameau]]

New try as the reftest failure looks suspicious...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bca9e5f39159

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8576530 [details] [diff] [review]
patch v2

Review of attachment 8576530 [details] [diff] [review]:
-----------------------------------------------------------------

For OS X, there are no regressions as far as retina support, so seems good to me.

Comment 7

[Alexandre Poirot [:ochameau]]

The new try is green.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5747865276f1

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5747865276f1

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 8576530 [details] [diff] [review]
patch v2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  bug 1107759

User impact if declined:
  2.2 FxOS simulator are buggy when trying to rotate the apps
Testing completed:
  Verified on 3.0 simulators on master.

Risk to taking this patch (and alternatives if risky):
  Patch only against screen.js that is only used on desktop.

String or UUID changes made by this patch:
  No.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for b2g37 uplift.

Comment 12

[Alexandre Poirot [:ochameau]]

Attachment: b2g27-2.2 patch

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/79a8767e838e