Closed Bug 1142080 Opened 8 years ago Closed 8 years ago

Apps are badly resize when toggling the orientation on b2g desktop

Categories

(Firefox OS Graveyard :: Runtime, defect)

defect
Not set
normal

Tracking

(firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S8 (20mar)
Tracking Status
firefox37 --- wontfix
firefox38 --- wontfix
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(2 files, 1 obsolete file)

It looks like since bug 1107759, the apps are badly resized when going into landscape and the app doesn't support landscape. We only see half of the app and a black area.
Attached patch patch v1 (obsolete) — Splinter Review
I don't know what happened in bug 1107759 and when we regressed so badly,
but here is a fix and I cleanup up the related code a bit.

It also fix support of default orientation different than portrait (cc:janx).
Attachment #8576028 - Flags: review?(fabrice)
Blocks: 1116611
Comment on attachment 8576028 [details] [diff] [review]
patch v1

Review of attachment 8576028 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: b2g/chrome/content/screen.js
@@ +198,1 @@
>      }

nit: let controlsHeight = controls ? controls.getBCR().height : 0

::: b2g/chrome/content/shell.css
@@ +20,3 @@
>    border: none;
> +  width: 100%;
> +  height: 100%;

that's a no-op change, right? if so, don't do it ;)
Attachment #8576028 - Flags: review?(fabrice) → review+
Attached patch patch v2Splinter Review
Fixed the nits.
Attachment #8576028 - Attachment is obsolete: true
Attachment #8576530 - Flags: review+
New try as the reftest failure looks suspicious...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bca9e5f39159
Comment on attachment 8576530 [details] [diff] [review]
patch v2

Review of attachment 8576530 [details] [diff] [review]:
-----------------------------------------------------------------

For OS X, there are no regressions as far as retina support, so seems good to me.
Attachment #8576530 - Flags: feedback+
The new try is green.
Assignee: nobody → poirot.alex
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5747865276f1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8576530 [details] [diff] [review]
patch v2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  bug 1107759

User impact if declined:
  2.2 FxOS simulator are buggy when trying to rotate the apps
Testing completed:
  Verified on 3.0 simulators on master.

Risk to taking this patch (and alternatives if risky):
  Patch only against screen.js that is only used on desktop.

String or UUID changes made by this patch:
  No.
Attachment #8576530 - Flags: approval-mozilla-b2g37?
Attachment #8576530 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Needs rebasing for b2g37 uplift.
Flags: needinfo?(poirot.alex)
Target Milestone: --- → 2.2 S8 (20mar)
Attached patch b2g27-2.2 patchSplinter Review
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.