1142115 - Clean up for/of loop in _addScript

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[James Long (:jlongster)]

Right now we need to intentionally create a fresh binding inside of the for/of loop in _addScript because SpiderMonkey doesn't do that automatically for for/of yet. When bug 1101653 is fixed we should remove that fresh binding.

Comment 1

[Tom Tromey :tromey]

I couldn't find whatever code this is referring to.
I imagine it's been refactored away.

Comment 2

[Tom Tromey :tromey]

... and now I found it.
https://dxr.mozilla.org/mozilla-central/rev/d29f84406483c721a13cf9a52936ecced0c5c98a/devtools/server/actors/script.js#1953

Comment 3

[Tom Tromey :tromey]

Stumbled across this yet again.

Comment 4

[Tom Tromey :tromey]

Attachment: Bug 1142115 - remove for/of scoping workaround;

Review commit: https://reviewboard.mozilla.org/r/145386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145386/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8873962 [details]
Bug 1142115 - remove for/of scoping workaround;

https://reviewboard.mozilla.org/r/145386/#review149324

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8873962 [details]
Bug 1142115 - remove for/of scoping workaround;

https://reviewboard.mozilla.org/r/145386/#review149334

Agree with jryans

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64af9e5dd9e1
remove for/of scoping workaround; r=bgrins,jryans

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64af9e5dd9e1