Clean up for/of loop in _addScript

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: jlongster, Assigned: tromey)

Tracking

({good-first-bug})

unspecified
Firefox 55
x86
Mac OS X
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Right now we need to intentionally create a fresh binding inside of the for/of loop in _addScript because SpiderMonkey doesn't do that automatically for for/of yet. When bug 1101653 is fixed we should remove that fresh binding.
(Reporter)

Updated

3 years ago
Depends on: 1101653
(Assignee)

Comment 1

a year ago
I couldn't find whatever code this is referring to.
I imagine it's been refactored away.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 2

a year ago
... and now I found it.
https://dxr.mozilla.org/mozilla-central/rev/d29f84406483c721a13cf9a52936ecced0c5c98a/devtools/server/actors/script.js#1953
Status: RESOLVED → REOPENED
Keywords: good-first-bug
Priority: -- → P3
Resolution: FIXED → ---
(Assignee)

Comment 3

9 months ago
Stumbled across this yet again.
Assignee: nobody → ttromey
Comment hidden (mozreview-request)

Comment 5

9 months ago
mozreview-review
Comment on attachment 8873962 [details]
Bug 1142115 - remove for/of scoping workaround;

https://reviewboard.mozilla.org/r/145386/#review149324
Attachment #8873962 - Flags: review+

Comment 6

9 months ago
mozreview-review
Comment on attachment 8873962 [details]
Bug 1142115 - remove for/of scoping workaround;

https://reviewboard.mozilla.org/r/145386/#review149334

Agree with jryans
Attachment #8873962 - Flags: review?(bgrinstead) → review+

Comment 7

9 months ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64af9e5dd9e1
remove for/of scoping workaround; r=bgrins,jryans

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/64af9e5dd9e1
Status: REOPENED → RESOLVED
Last Resolved: a year ago9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.