Closed Bug 1142115 Opened 5 years ago Closed 3 years ago

Clean up for/of loop in _addScript

Categories

(DevTools :: Debugger, defect, P3)

x86
macOS
defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jlong, Assigned: tromey)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Right now we need to intentionally create a fresh binding inside of the for/of loop in _addScript because SpiderMonkey doesn't do that automatically for for/of yet. When bug 1101653 is fixed we should remove that fresh binding.
Depends on: 1101653
I couldn't find whatever code this is referring to.
I imagine it's been refactored away.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
... and now I found it.
https://dxr.mozilla.org/mozilla-central/rev/d29f84406483c721a13cf9a52936ecced0c5c98a/devtools/server/actors/script.js#1953
Status: RESOLVED → REOPENED
Keywords: good-first-bug
Priority: -- → P3
Resolution: FIXED → ---
Stumbled across this yet again.
Assignee: nobody → ttromey
Comment on attachment 8873962 [details]
Bug 1142115 - remove for/of scoping workaround;

https://reviewboard.mozilla.org/r/145386/#review149334

Agree with jryans
Attachment #8873962 - Flags: review?(bgrinstead) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64af9e5dd9e1
remove for/of scoping workaround; r=bgrins,jryans
https://hg.mozilla.org/mozilla-central/rev/64af9e5dd9e1
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.