TextureClientD3D11 returns without updating mIsLocked if an error occurs

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla39
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Not a serious bug since when this happens we are already in a bad situation, but it's best not to add more invalid states on top of it.
(Assignee)

Comment 1

4 years ago
Created attachment 8576099 [details] [diff] [review]
Don't return if readback fails.
Attachment #8576099 - Flags: review?(jmuizelaar)
(Assignee)

Updated

4 years ago
Whiteboard: [gfx-noted]
Comment on attachment 8576099 [details] [diff] [review]
Don't return if readback fails.

Review of attachment 8576099 [details] [diff] [review]:
-----------------------------------------------------------------

I hope this is safer.
Attachment #8576099 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/14d19980f27d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.