1142222 - boolForKey returns false for undefined keys

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Working on the search suggestions opt in, I found the following line was always false:

self.shouldShowSearchSuggestionsOptIn = prefs.boolForKey(ShowSearchSuggestionsOptIn) ?? true

Turns out userDefaults.boolForKey never returns nil when the pref isn't defined, returning false instead.

I then tried to add a simple nil assertion for undefined prefs, clearing prefs before each run in ProfilePrefsTests. That's where things got interesting since, for some reason, userDefaults.removePersistentDomainForName() simply has no effect for our app group. The workaround of manually removing each key works, but it's still unclear whether this is an iOS bug or our own.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8576205 [details] [review]
Pull request

Thanks.  I explicitly tried to avoid this kind of coercion bullshit, and still failed :(