1142241 - Stop using getParent() in js::GetObjectEnvironmentObjectForFunction

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Really, the consumer cares only about the DynamicWithObject case here.  So it doesn't even matter too much what we return in the other cases, but let's just return the global.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using getParent() in js::GetObjectEnvironmentObjectForFunction

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8576243 [details] [diff] [review]
Stop using getParent() in js::GetObjectEnvironmentObjectForFunction

Review of attachment 8576243 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/ScopeObject.cpp
@@ +2501,5 @@
>  }
>  
>  // See declaration and documentation in jsfriendapi.h
>  JS_FRIEND_API(JSObject *)
>  js::GetObjectEnvironmentObjectForFunction(JSFunction *fun)

This is a bizarre function with a bizarre user.  No wonder it's friendapi.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/326e615308cc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/326e615308cc