Don't split interfaces between libical and ical.js

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1
x86
Mac OS X

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Dynamically loading the xpt file like we do makes the packager cry when it attempts to link xpts. We don't actually have to do that if we just have an extra interface that extends the base and adds the [notxpcom] methods.
(Assignee)

Comment 1

2 years ago
Created attachment 8576268 [details] [diff] [review]
Fix - v1
Attachment #8576268 - Flags: review?(geoff)
Comment on attachment 8576268 [details] [diff] [review]
Fix - v1

Review of attachment 8576268 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no expert on the C++ side of things, but this looks good to me. FWIW more lines of context would've been really useful here.

::: calendar/base/backend/libical/calRecurrenceRule.cpp
@@ +211,1 @@
>              aRecurEnd->GetInTimezone(cal::UTC(), getter_AddRefs(dt));

What does |dt| do in this method now? Did you mean to use icaldt here?
Attachment #8576268 - Flags: review?(geoff) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8576593 [details] [diff] [review]
Fix - v2

What a great find. Not only was the C++ code wrong, but also it uncovered a bug in ical.js. Here is a new patch with more context and a unit test.
Attachment #8576268 - Attachment is obsolete: true
Attachment #8576593 - Flags: review?(geoff)
Attachment #8576593 - Flags: review?(geoff) → review+
(Assignee)

Updated

2 years ago
Attachment #8576593 - Flags: approval-calendar-aurora+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
https://hg.mozilla.org/comm-central/rev/bc959dd6181f

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1

Comment 5

2 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/3e65bc7a7758
(Assignee)

Updated

2 years ago
Target Milestone: 4.1 → 4.0
You need to log in before you can comment on or make changes to this bug.