1142261 - Don't split interfaces between libical and ical.js

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Dynamically loading the xpt file like we do makes the packager cry when it attempts to link xpts. We don't actually have to do that if we just have an extra interface that extends the base and adds the [notxpcom] methods.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 8576268 [details] [diff] [review]
Fix - v1

Review of attachment 8576268 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no expert on the C++ side of things, but this looks good to me. FWIW more lines of context would've been really useful here.

::: calendar/base/backend/libical/calRecurrenceRule.cpp
@@ +211,1 @@
>              aRecurEnd->GetInTimezone(cal::UTC(), getter_AddRefs(dt));

What does |dt| do in this method now? Did you mean to use icaldt here?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

What a great find. Not only was the C++ code wrong, but also it uncovered a bug in ical.js. Here is a new patch with more context and a unit test.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/bc959dd6181f

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-aurora/rev/3e65bc7a7758