1142282 - Remove parent arguments from NewNativeObjectWith*Proto

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove the parent argument of NewNativeObjectWithGivenProto

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the parent argument of NewNativeObjectWithGivenTaggedProto

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove the parent argument of NewNativeObjectWithClassProto

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 8576295 [details] [diff] [review]
part 1.  Remove the parent argument of NewNativeObjectWithGivenProto

Review of attachment 8576295 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Debugger.cpp
@@ -5824,5 @@
>          RootedObject proto(cx, GlobalObject::getOrCreateArrayPrototype(cx, global));
>          if (!proto)
>              return false;
> -        argsobj = NewNativeObjectWithGivenProto(cx, &DebuggerArguments_class, proto,
> -                                                GlobalObject::upcast(global));

You're removing an awful lot of GlobalObject::upcast uses.  Maybe worth seeing if all could be killed somehow.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8576296 [details] [diff] [review]
part 2.  Remove the parent argument of NewNativeObjectWithGivenTaggedProto

Review of attachment 8576296 [details] [diff] [review]:
-----------------------------------------------------------------

If these functions really are unused, feel free to remove them.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Maybe worth seeing if all could be killed somehow.

After bug 1142296 lands and removes a few more, we can think about it.

> If these functions really are unused, feel free to remove them.

They're unused, but I'm kinda assuming they got added for a reason....

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1ec6a6aa82a
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f898cc3cb9
https://hg.mozilla.org/integration/mozilla-inbound/rev/761c4f4f4af8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1ec6a6aa82a
https://hg.mozilla.org/mozilla-central/rev/e3f898cc3cb9
https://hg.mozilla.org/mozilla-central/rev/761c4f4f4af8