Closed
Bug 1142295
Opened 11 years ago
Closed 10 years ago
DR_State::ParseRulesFile leaks |inFile|
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: erahm, Assigned: joseriosneto, Mentored)
Details
(Whiteboard: [MemShrink:P3][CID 1286577][lang=c++][good first bug])
Attachments
(1 file)
|
753 bytes,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
If the |GECKO_DISPLAY_REFLOW_RULES_FILE| env var is set, we leak |inFile| [1] in DR_State::ParseRulesFile.
[1] https://hg.mozilla.org/mozilla-central/annotate/bc6aeea72290/layout/generic/nsFrame.cpp#l9416
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink][CID 1286577] → [MemShrink:P3][CID 1286577]
|
Reporter | |
Updated•11 years ago
|
Mentor: erahm
Whiteboard: [MemShrink:P3][CID 1286577] → [MemShrink:P3][CID 1286577][lang=c++][good first bug]
Eric, here's a patch closing the fd.
Attachment #8606054 -
Flags: review?(erahm)
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → joseriosneto
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8606054 [details] [diff] [review]
bug1142295_fix_fd_leak.patch
Review of attachment 8606054 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. r=me
As this is in core code (not a tool or test) I'm going to push it to the try server before landing.
Attachment #8606054 -
Flags: review?(erahm) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
|
|
Reporter | |
Comment 4•10 years ago
|
||
The try push looks good, lets get this landed.
|
|
Reporter | |
Comment 5•10 years ago
|
||
|
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•