1142296 - Remove parent argument from NewObjectWithGivenProto

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the parent argument from NewObjectWithGivenProto

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8576306 [details] [diff] [review]
Remove the parent argument from NewObjectWithGivenProto

Review of attachment 8576306 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsscript.cpp
@@ +1355,5 @@
>  
>  ScriptSourceObject *
>  ScriptSourceObject::create(ExclusiveContext *cx, ScriptSource *source)
>  {
> +    RootedObject object(cx, NewObjectWithGivenProto(cx, &class_, NullPtr()));

Seems like a bunch of these that pass a constant class should use NewObjectWithGivenProto<T> instead, maybe.  (Or maybe we could imagine that class is constant everywhere, because variable class is just weird?  Excepting maybe in JSAPI function spots.)

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Seems like a bunch of these that pass a constant class should use
> NewObjectWithGivenProto<T> instead, maybe.

Could be.  I can't tell what the rhyme/reason behind these baroque newobject APIs is.... :(

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b105c303ca33

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b105c303ca33