1142312 - Unexpected reader view output when viewing random Yahoo article

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Peter deHaan [:pdehaan]]

Attachment: Veteran_Wraps_Baby_in_American_Flag__Photo_Sparks_Controversy.png

Not sure if this belongs here or in https://github.com/mozilla/readability

Browsing to current top story on Yahoo! https://gma.yahoo.com/veteran-wraps-baby-american-flag-photo-sparks-controversy-175203890--abc-news-topstories.html

I'm using FF 39.0a1 (2015-03-11) and get a bunch of video details and JSON dump instead of a readable article.

Comment 1

[Peter deHaan [:pdehaan]]

Scraping Ebay also looks weird: http://www.ebay.com/itm/191517921896

Basically I'm trying to go through the first page or two of http://www.alexa.com/topsites and seeing how many top sites render as expected (and consistent w/ Safari's reader output).

Comment 2

[Peter deHaan [:pdehaan]]

Attachment: Nike_Limited_Edition_N7_Ombre_Inneva_Free_Woven_Size_9_New_Supreme_Yeezy.png

Comment 3

[Evan Tseng [:evanxd]]

Sent a pull request[1] for review.

[1]: https://github.com/mozilla/readability/pull/329/commits/d78ee2dab688c5b66d568b32831508bb18819381

Comment 4

[Evan Tseng [:evanxd]]

Landed: https://github.com/mozilla/readability/commit/c83826c3267507033e330921ba395671b127c293

Comment 5

[Evan Tseng [:evanxd]]

Forgot land code in m-c.

Comment 6

[Evan Tseng [:evanxd]]

Attachment: No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543,

Review commit: https://reviewboard.mozilla.org/r/98730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98730/

Comment 7

[Evan Tseng [:evanxd]]

Hi Gijs,

The patch updates readability from github repo, includes fix for Bug 1142312 and Bug 1285543. Could you help land it? Thanks.

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8818781 [details]
No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98730/diff/1-2/

Comment 9

[:Gijs (he/him)]

Comment on attachment 8818781 [details]
No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543,

https://reviewboard.mozilla.org/r/98730/#review99122

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57ab844a366f
No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543, r=Gijs

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/autoland/rev/52289f061044b578ab2a89bda8ae0372857f6032 for robocop bustage. https://treeherder.mozilla.org/logviewer.html#?job_id=7964175&repo=autoland

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8818781 [details]
No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98730/diff/2-3/

Comment 13

[Evan Tseng [:evanxd]]

The patch just changes the test result. I've updated for it. Let's wait for the result. If everything is good, let's land again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=53d16650104d

Comment 14

[:Gijs (he/him)]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #13)
> The patch just changes the test result. I've updated for it. Let's wait for
> the result. If everything is good, let's land again.
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=53d16650104d

You didn't ask for android builds. I triggered extra jobs and hope that works.

Comment 15

[Evan Tseng [:evanxd]]

Thanks. I also pushed a new try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd10ad6d434d

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d23c29c47f
No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543, r=Gijs

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c3d23c29c47f