Closed Bug 1142350 Opened 5 years ago Closed 3 years ago

investigate removing nsIUserCertPicker, nsICertPickDialogs, and associated unused cruft

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: keeler, Assigned: Cykesiopka)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

It doesn't look like nsIUserCertPicker is used anymore, so the interface and its implementation can be removed. As far as I can tell, that's the only user of nsICertPickDialogs, so I think the interface, its implementation, and associated xul/js/l10n strings/etc. can also be removed.
Unfortunately this might still be in use in c-c (not sure whether this code is dead or not though):
https://hg.mozilla.org/comm-central/annotate/84ac3c711098/mailnews/extensions/smime/content/am-smime.js#l271
Ah, good call. Maybe we can move it to c-c and remove it from m-c.
(In reply to Cykesiopka from comment #1)
> Unfortunately this might still be in use in c-c (not sure whether this code
> is dead or not though):

It's not, and it is essential for configuring S/MIME signing or encryption, actually, see also https://support.mozilla.org/en-US/kb/configuration-options-certificates
Whiteboard: [psm-cleanup]
P2 because I intend to remove this code within a few weeks.

I will look into moving this code to c-c, but if that fails, I will just remove the code from m-c.

Alternatively, if someone working on c-c code would like to reimplement the code in a cleaner fashion (the current code suffers from basically the same issues as the client auth code as pointed out in Bug 307081), then I can wait for that work to finish first.
Priority: -- → P2
Blocks: 1297368
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [psm-cleanup] → [psm-assigned]
Comment on attachment 8793284 [details]
Bug 1142350 - Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central.

https://reviewboard.mozilla.org/r/80070/#review78916

Awesome - r=me.
Attachment #8793284 - Flags: review?(dkeeler) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/75a0213cc965
Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central. r=keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75a0213cc965
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.