1142350 - investigate removing nsIUserCertPicker, nsICertPickDialogs, and associated unused cruft

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

It doesn't look like nsIUserCertPicker is used anymore, so the interface and its implementation can be removed. As far as I can tell, that's the only user of nsICertPickDialogs, so I think the interface, its implementation, and associated xul/js/l10n strings/etc. can also be removed.

Comment 1

[:Cykesiopka]

Unfortunately this might still be in use in c-c (not sure whether this code is dead or not though):
https://hg.mozilla.org/comm-central/annotate/84ac3c711098/mailnews/extensions/smime/content/am-smime.js#l271

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Ah, good call. Maybe we can move it to c-c and remove it from m-c.

Comment 3

[Kaspar]

(In reply to Cykesiopka from comment #1)
> Unfortunately this might still be in use in c-c (not sure whether this code
> is dead or not though):

It's not, and it is essential for configuring S/MIME signing or encryption, actually, see also https://support.mozilla.org/en-US/kb/configuration-options-certificates

Comment 4

[:Cykesiopka]

P2 because I intend to remove this code within a few weeks.

I will look into moving this code to c-c, but if that fails, I will just remove the code from m-c.

Alternatively, if someone working on c-c code would like to reimplement the code in a cleaner fashion (the current code suffers from basically the same issues as the client auth code as pointed out in Bug 307081), then I can wait for that work to finish first.

Comment 5

[:Cykesiopka]

Attachment: Bug 1142350 - Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central.

The code is used in comm-central, but is unused in mozilla-central. It will be
imported into comm-central in Bug 1297368.

Review commit: https://reviewboard.mozilla.org/r/80070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80070/

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8793284 [details]
Bug 1142350 - Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central.

https://reviewboard.mozilla.org/r/80070/#review78916

Awesome - r=me.

Comment 7

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a7daa5338134c1e589a7ddf3ec360e6ea5850f2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75a0213cc965
Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central. r=keeler

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/75a0213cc965