1142381 - Symlinked apps in outoftree_apps folder throwing error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Kevin Grandon :kgrandon]

When symlinking apps into outoftree_apps folder I'm seeing the following error:

Exception: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsILocalFile.lastModifiedTime]"  nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/rebuild.js :: getTimestamp/</< :: line 19"  data: no]
getTimestamp/</<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/rebuild.js:19:8
getTimestamp/<@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/rebuild.js:17:6
getTimestamp@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/rebuild.js:12:2
exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/rebuild.js:89:16
exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/kevin/workspace/gaia/build/app.js:120:29
CommonjsRunner.prototype.run@/Users/kevin/workspace/gaia/build/xpcshell-commonjs.js:168:4
run@/Users/kevin/workspace/gaia/build/xpcshell-commonjs.js:183:2
@-e:1:0

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1142381_symlinked_apps_fix > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8576422 [details] [review]
[gaia] KevinGrandon:bug_1142381_symlinked_apps_fix > mozilla-b2g:master

Ricky - I'm not really sure what's going on here, but for some reason my symlinked apps stopped working. This patch seems to fix it - is it something you'd be comfortable landing?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8576422 [details] [review]
[gaia] KevinGrandon:bug_1142381_symlinked_apps_fix > mozilla-b2g:master

IIRC, I guess you create a symlink that links to an app but delete that app in your project folder so that cause such error.
I'm fine to this fix. r=me Thanks!

Comment 4

[Kevin Grandon :kgrandon]

Hmm, I'm not sure if I follow you. I'm not deleting anything, I just have a symlink to an app somewhere in my tree. I wonder if the file module does not return lastModifiedTime properly for a symlink?

I'll go ahead and land this for now if you don't think it's going to cause any problems, and we can investigate further later. Thanks for the quick review.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f73a7dc52b662edd3d4490ca2d8300eff4838090