Closed
Bug 1142383
Opened 9 years ago
Closed 8 years ago
[RTSP] More RTSP testcases
Categories
(Firefox OS Graveyard :: RTSP, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jhao, Assigned: jhao)
References
Details
Attachments
(3 files, 2 obsolete files)
Bug 1032111 has a basic testcase for RTSP. We'll add more testcases. 1. Testing more video formats 2. Testing more use cases
Assignee | ||
Comment 1•9 years ago
|
||
This patch is based on the patch of Bug 1032111. It adds a testcase for pausing an RTSP video.
Attachment #8576426 -
Flags: feedback?(ettseng)
Assignee | ||
Comment 2•9 years ago
|
||
Ethan, do you think the above patch is the kind of test we have in mind? Is the style OK? Furthermore, I plan to write testcases in separate js files for each pair of (video type, action), so that when a testcase fails, we will know what's wrong right away.
Blocks: 998899
Comment 3•9 years ago
|
||
Comment on attachment 8576426 [details] [diff] [review] test-h264-pause.patch The patch itself is fine. But I am concerned about the layout/deployment of test scripts. Right now we support at least 8 different RTP payload formats [1]. There could be a dozen of test cases/scenarios (play, pause, seek, EOS, ...) and we can expect many more to be added in the future. If we divide test scripts in this two-dimension way, the number of scripts would increase too quickly. Imagine just the basic cases describe above, we would have 8 * 4 = 32 script files. And every time we add a case, we need to add 8 individual files. I think we can separate test scripts only by scenarios, and test all supported formats in the same script. This is also the way media team deploy their Mochitest test cases. [1] https://wiki.mozilla.org/Networking/RTSP#Supported_RTP_Payload_Formats_.28Codecs.29
Attachment #8576426 -
Flags: feedback?(ettseng) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
I've been trying to add other video formats to our testcases for some time. Partners often tests .3gp files, so I tried to add sample_50kbit.3gp to the test case. However, it couldn't be played properly. I also tried sample.3gp in gecko/dom/media/test/ and it still didn't work. Then, I found that in https://dxr.mozilla.org/mozilla-central/source/dom/media/test/manifest.js#21 A comment clearly states that emulator codecs can't pass tests of .3gp files, so I think we'll have to give up on .3gp files.
Assignee | ||
Comment 5•9 years ago
|
||
Also, I haven't found a way to hint .mov files other than buying Apple Quicktime Pro. Hinting is necessary for videos to be put on Darwin server. It seems that testing .mov files are also huge problems.
Comment 6•9 years ago
|
||
(In reply to Jonathan Hao [:jhao] from comment #5) > Also, I haven't found a way to hint .mov files other than buying Apple > Quicktime Pro. > Hinting is necessary for videos to be put on Darwin server. > It seems that testing .mov files are also huge problems. Not a huge problem. If you are certain that QuickTime Pro could meet our needs, I'm pretty sure many colleagues (especially people in the media team) have that tool, and could help to hint mov files for us. Even this option doesn't work, QuickTime Pro is not unaffordable to us that we can purchase it on our own. We can discuss this detail offline. :)
Assignee | ||
Comment 7•9 years ago
|
||
* The changes in Android.mk is to add sample_100kbit.mov to /system/media/streaming/ in target device. * sample_100kbit.mov is hinted to enable streaming
Assignee | ||
Comment 8•9 years ago
|
||
New changes will move all files in /sustem/media/streaming to /data/misc/streaming/media, since now we could have many media files. This pull request is for repository "device_generic_goldfish", whereas the previous attachment 8583538 [details] [review] is for repository "darwinstreamingserver".
Assignee | ||
Comment 9•9 years ago
|
||
|gTestSuite.urls| contains the urls of videos to be tested |gTestSuite.urls.doTest(singleTest)| will run |singleTest| on each urls. |singltTest| should be a callback taking a url as argument, and returning a promise.
Assignee | ||
Comment 10•9 years ago
|
||
Latest WIP patch of marionette testcases. Add a test for seeking based on dom/media/test/test_seek-1.html
Attachment #8576426 -
Attachment is obsolete: true
Attachment #8583575 -
Attachment is obsolete: true
Comment 11•8 years ago
|
||
Jonathan, since we are not actively working on RTSP for a long time. I am going to close this bug and its meta bug. If anyone is interested in RTSP in FxOS, please reopen them.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•