Created attachment 8576453 [details] screenshot separator lines in popup menus are no longer visible on osx. the background colour of the menu is #e6e6e6 and the separator is #e5e5e5, making it pretty well invisible.
Markus, any ideas? Glob, do you know when this broke?
Keywords: regression, regressionwindow-wanted
I am not seeing this on Nightly.
(In reply to Stephen Horlander [:shorlander] from comment #2) > I am not seeing this on Nightly. odd; i see it in nightly and aurora. i'm currently running mozregression while wishing i had a faster internet connection.
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b3fa9d6b1310&tochange=b46cb1ef16f8 bug 1045213 i guess (i'm running 10.10.2).
Status: NEW → ASSIGNED
QA Contact: mstange
Summary: separator lines in popup menus are no longer visible on osx → separator lines in popup menus are no longer visible on osx when "Reduce transparency" is checked in the system accessibility prefs
Component: Theme → Widget: Cocoa
Product: Firefox → Core
Version: unspecified → 38 Branch
Created attachment 8576837 [details] [diff] [review] patch
Comment on attachment 8576837 [details] [diff] [review] patch + // When vibrancy is turned off system-wide, the window's rounded corner + // mask that we apply for menus isn't used, so we need to do our own + // rounded corner drawing here. I don't understand this comment. Isn't this code (DrawVibrancyBackground()) only ever called when VibrancyManager::SystemSupportsVibrancy() returns true?
Yes, but SystemSupportsVibrancy() also returns true if "Reduce transparency" is checked.
How does that match with "when vibrancy is turned off system-wide"? Is that what "reduce transparency" means?
Hmm, maybe we should call that something else then. I see how it's confusing. I'll reformulate the comment and request review with a fixed patch.
Created attachment 8578205 [details] [diff] [review] patch The comment should be better now.
Comment on attachment 8578205 [details] [diff] [review] patch That comment makes a lot more sense.
Attachment #8578205 - Flags: review?(smichaud) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.