separator lines in popup menus are no longer visible on osx when "Reduce transparency" is checked in the system accessibility prefs

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glob, Assigned: mstange)

Tracking

({regression})

38 Branch
mozilla39
x86
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8576453 [details]
screenshot

separator lines in popup menus are no longer visible on osx.

the background colour of the menu is #e6e6e6 and the separator is #e5e5e5, making it pretty well invisible.
Markus, any ideas?

Glob, do you know when this broke?
Flags: needinfo?(mstange)
Flags: needinfo?(glob)
Keywords: regression, regressionwindow-wanted
I am not seeing this on Nightly.
(Reporter)

Comment 3

4 years ago
(In reply to Stephen Horlander [:shorlander] from comment #2)
> I am not seeing this on Nightly.

odd; i see it in nightly and aurora.

i'm currently running mozregression while wishing i had a faster internet connection.
(Assignee)

Comment 5

4 years ago
Got it.
Status: NEW → ASSIGNED
Flags: needinfo?(mstange)
QA Contact: mstange
Summary: separator lines in popup menus are no longer visible on osx → separator lines in popup menus are no longer visible on osx when "Reduce transparency" is checked in the system accessibility prefs
(Assignee)

Updated

4 years ago
Keywords: regressionwindow-wanted
(Assignee)

Updated

4 years ago
Blocks: 1045213
(Assignee)

Updated

4 years ago
Component: Theme → Widget: Cocoa
Product: Firefox → Core
Version: unspecified → 38 Branch
(Assignee)

Comment 6

4 years ago
Created attachment 8576837 [details] [diff] [review]
patch
Attachment #8576837 - Flags: review?(smichaud)
Comment on attachment 8576837 [details] [diff] [review]
patch

+      // When vibrancy is turned off system-wide, the window's rounded corner
+      // mask that we apply for menus isn't used, so we need to do our own
+      // rounded corner drawing here.

I don't understand this comment.  Isn't this code (DrawVibrancyBackground()) only ever called when VibrancyManager::SystemSupportsVibrancy() returns true?
(Assignee)

Comment 8

4 years ago
Yes, but SystemSupportsVibrancy() also returns true if "Reduce transparency" is checked.
How does that match with "when vibrancy is turned off system-wide"?  Is that what "reduce transparency" means?
(Assignee)

Comment 10

4 years ago
Hmm, maybe we should call that something else then. I see how it's confusing.

I'll reformulate the comment and request review with a fixed patch.
(Assignee)

Comment 11

4 years ago
Created attachment 8578205 [details] [diff] [review]
patch

The comment should be better now.
Assignee: nobody → mstange
Attachment #8576837 - Attachment is obsolete: true
Attachment #8576837 - Flags: review?(smichaud)
Attachment #8578205 - Flags: review?(smichaud)
Comment on attachment 8578205 [details] [diff] [review]
patch

That comment makes a lot more sense.
Attachment #8578205 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/mozilla-central/rev/58b677bbf8b8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.