Closed Bug 1142420 Opened 5 years ago Closed 5 years ago

configure should test that C and C++ compiler versions are the same

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

Configure should test that the C and C++ compiler versions are the same.  At a minimum, this is needed to make our compiler version checks sane; we do tests on only one of the versions.  It's probably also good hygiene, since I suspect most cases of people trying to build with different versions are mistakes, and ones that might not be caught quickly.  (I've certainly done it; see bug 227867.)
I tested locally that both checks give the expected error if I
temporarily change the != to an =.
Attachment #8576781 - Flags: review?(mh+mozilla)
Attachment #8576781 - Flags: review?(mh+mozilla) → review+
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e76c33c4d452 since the other patch caused a bustage and this 2 csets were tight togehter
Flags: needinfo?(dbaron)
Depends on: 1142352
https://hg.mozilla.org/mozilla-central/rev/21a66a6f1d61
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Flags: needinfo?(dbaron)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.