Closed Bug 1142433 Opened 6 years ago Closed 6 years ago
Duration not properly read from MEHD atom
Introduced in bug 1120075 It appears that the duration found in the movie extend header is defined according to the timescale in the movie header (mvhd) atom. And not in milliseconds as first assumed (all the samples I had use a timescale = 1000)
properly adjust duration according to movie header timescale
Attachment #8576546 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
6 years ago
Attachment #8576546 - Flags: review?(ajones) → review+
This cause a lot of webref test to fail. IT appears that was cause we were incorrectly calculating durations before. So few tests now passes.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/aa48e92f7e57 - looks like the best two places to catch the failures are OS X 10.10 opt, in media-source/mediasource-append-buffer.html like https://treeherder.mozilla.org/logviewer.html#?job_id=7560429&repo=mozilla-inbound and Windows 8 opt in media-source/mediasource-remove.html like https://treeherder.mozilla.org/logviewer.html#?job_id=7566449&repo=mozilla-inbound
Update webref. We still timeout due to bug 1128332 that now occurs on all platforms.
Attachment #8577992 - Flags: review?(karlt)
This bugs needs to be uplifted as otherwise webref tests will now fail (now that they have been re-activated due to bug 1144509)
Comment on attachment 8576546 [details] [diff] [review] Properly scale duration found in movie extend header box Approval Request Comment [Feature/regressing bug #]:1142433 [User impact if declined]:Tests recently re-enabled will fail. [Describe test coverage new/current, TreeHerder]:Been on m-c for over a week. [Risks and why]: Low. The tests were re-enabled, previously disabled. Problem was always there [String/UUID change made/needed]:none
Attachment #8576546 - Flags: approval-mozilla-aurora?
the approval request is for both patches.
Attachment #8576546 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/07e8fa9ef9e7 https://hg.mozilla.org/releases/mozilla-aurora/rev/558460c05b39 Part 2 included a revert of rev 0b7762fb7639 as well.
You need to log in before you can comment on or make changes to this bug.