Closed Bug 1142458 Opened 9 years ago Closed 9 years ago

sccache should make MACOSX_DEPLOYMENT_TARGET part of the cache key

Categories

(Release Engineering :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

As per bug 1142006, the MACOSX_DEPLOYMENT_TARGET environment variable can influence the result of compilation. As such, its value should be part of the cache key.
Comment on attachment 8576591 [details] [diff] [review]
Make MACOSX_DEPLOYMENT_TARGET part of the cache key

Looking at the ENVIRONMENT section of the gcc man page, there is also an IPHONEOS_DEPLOYMENT_TARGET - might want to preemptively add that one as well.
Attachment #8576591 - Flags: review?(mshal) → review+
Gross. Could we stop using this as an environment variable and just use -mmacosx-version-min instead? They do the same thing. Presumably sccache would handle it on the commandline properly?
It would, but as a general purpose tool, the issue would still exist.
QA Contact: pmoore → mshal
Attachment #8592013 - Flags: review?(mshal) → review+
Blocks: 1155476
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: