1142484 - Update Shumway to version 0.10.268

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

Changes:

#2104 No DOM operation on script initialization.
#2107 Few compatibility fixes to make main page showing in IE10
#2108 Bug 1116281 - Using newChannel2 in the extension.
#2109 Moves localStrage from the core code.
#2111 Bug 1141375 - Refactoring ShumwayCom to use Cu.cloneInto
#2103 Misc parser fixes
#2112 Moves ExternalInterface and FileLoader logic from ShumwayCom
#2114 Simple heuristics to reject loading of crossdomain SWFs.
#2115 Allows shuobject to be used crossdomain.
#2116 Bug 1141343 - be more forgiving when parsing JPEG images
#2118 Bug 1141341 - Stops processing LZMA input after first error.

Comment 1

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.10.268

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2112dde08f1

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8576648 [details] [diff] [review]
Update Shumway to version 0.10.268

Review of attachment 8576648 [details] [diff] [review]:
-----------------------------------------------------------------

The content/chrome communication stuff is so, so much nicer!

::: browser/extensions/shumway/chrome/ExternalInterface.jsm
@@ +53,5 @@
> +};
> +
> +function getBoolPref(pref, def) {
> +  try {
> +    return Services.prefs.getBoolPref(pref);

Would be nice to change this, and all other pref getter things, to [that jsm that allows providing defaults, whose name I forgot]. No need to do that now, though.

::: browser/extensions/shumway/chrome/RtmpUtils.jsm
@@ +126,2 @@
>  
> +      setLoadCallback: function (callback) {

This being Firefox-only code, you can use shorthand method declarations: `setLoadCallback(callback) {},`

No need to fix before landing, just for future reference.

::: browser/extensions/shumway/chrome/ShumwayCom.jsm
@@ +50,4 @@
>      // Exposing ShumwayCom object/adapter to the unprivileged content -- setting
>      // up Xray wrappers.
> +    var wrapped = {
> +      enableDebug: function enableDebug() {

Same as before: all these can be shorthand method definitions.

@@ +333,5 @@
> +    var isWhitelistedProtocol = /^(http|https):\/\//i.test(url);
> +    if (!isWhitelistedProtocol || !this.allowScriptAccess) {
> +      return;
> +    }
> +    // ...and only when user input is in-progress.

Nice comments.

Comment 3

[Till Schneidereit [:till]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c26740d56f23

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c26740d56f23