1142490 - Update the reading list according to latest ux specification

Status: RESOLVED FIXED

(Firefox for iOS :: Reading List, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

See the design specification in bug 1126486

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/219

This patch adds a button bar to reader mode. Couple of notes:

* I could not correctly get the scrolling of the toolbars to work with this new bar added. So to not block on that I have *temporarily* disabled the hiding of the button bars. I will file a followup to fix this as soon as possible. I'd like to land this first so that it can be looked at.
* Not all the buttons work. This is because some of the underlying reading list storage has not been committed yet. I have added `TODO` comments in the code and will file a followup for the database changes needed.
* I have removed the old hack of a long press on the star button to add an item to the reading list. This can now be done with a press on the Add to Reading List button in this new toolbar. Note the second point though, the button will not just yet change to a trashcan icon until the database changes have been done.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/220

Ignore previous comment. This is the right PR and comment.

This patch brings the Reading List home panel up to date with latest UX specs. Couple of notes:

* As an experiment I have put all constants, offsets, fonts, colors in a `ReadingListCellUX` struct as `static` members. This makes it easy for the UX team to fiddle with these settings. Lets see if this works or not. It makes the code a little more difficult to handle because of a layer of indirection but maybe it makes the 'tweak things to perfection' easier.
* For the left and right swiping of the row (for Mark as Read/Unread and Delete) I have imported the `SWTableCellView` dependency. This did not work as a Carthage dependency so I imported the sources straight into the `ThirdParty` directory.
* A bunch of things in this list do not work because they depend on database / storage changes. These are marked with `TODO Hook up Data Store` and will be addressed in a followup bug.

Enjoy