Closed Bug 1142494 Opened 5 years ago Closed 5 years ago

Don't try to package the steeplechase tests if webrtc is disabled

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file)

We were hitting bustage on Emulator L builds during packaging because webrtc was disabled and it was trying to package the steeplechase tests. We shouldn't try to do so unless webrtc is enabled.
Attached patch patchSplinter Review
Try confirms that this works as expected. Nils, speak now or forever hold your peace if there's any reason to not do this :)
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8576696 - Flags: review?(gps)
Attachment #8576696 - Flags: feedback?(drno)
Comment on attachment 8576696 [details] [diff] [review]
patch

Review of attachment 8576696 [details] [diff] [review]:
-----------------------------------------------------------------

If I understand the idea correct this only means: don't packages steeplechase (plus its tests) if MOZ_WEBRTC is not defined. That sounds perfectly reasonable.

My only question/concern is: does this affect the *tests.zip file we publish together with the binary tarballs?
Because our current steeplechase setup in the MV QA lab extracts steeplechase from these test zip files. So excluding steeplechase from that would cause major trouble for us (my + assumes that your patch is not going that far :-) ).
Attachment #8576696 - Flags: feedback?(drno) → feedback+
I don't see how it would affect tests.zip except for platforms where packaging them would have been useless anyway (i.e. they wouldn't be able to run on a webrtc-disabled build anyway). Below are my Try pushes if you want to take a look at the packages and verify, though.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a65bea9f145a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=721313d119fd
Rank: 25
Flags: firefox-backlog+
Priority: -- → P2
Attachment #8576696 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/b3ae8d7b0426
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.