Improve logging and tighten assertions on the Compositor side.

RESOLVED FIXED in Firefox 40

Status

()

Core
Graphics: Layers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla40
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The MOZ_ASSERT in HandleError was disabled in bug 1107718, I assume because it made it harder to investigate device resets in debug builds.
We should put it back (but not trigger the assertion in the case of device resets) in the form of a gfxCriticalError to get better information in crash-stats.

Some of the gfxCriticalError logs in CompositorD3D11/D3D9 don't have error codes so we should add those.
Whiteboard: gfx-noted
(Assignee)

Comment 1

3 years ago
It looks like the DeviceManagerD3D9 failed to initialize after a device reset. In some of the crashes we can see from the gfxCriticalError logs that it is the case, but surprisingly there are many cases where nothing shows in the gfxCriticalError log even though the device initialization has most of its error cases covered by the log.
Digging...
(Assignee)

Comment 2

3 years ago
(In reply to Nicolas Silva [:nical] from comment #1)
> It looks like the DeviceManagerD3D9 failed to initialize after a device
> reset. In some of the crashes we can see from the gfxCriticalError logs that
> it is the case, but surprisingly there are many cases where nothing shows in
> the gfxCriticalError log even though the device initialization has most of
> its error cases covered by the log.
> Digging...

oops, I meant to post this in bug 1143653.
(Assignee)

Comment 3

3 years ago
Created attachment 8583872 [details] [diff] [review]
windows-compositor-asserts
Attachment #8583872 - Flags: review?(bas)
Attachment #8583872 - Flags: review?(bas) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/aeaa4920fd59
https://hg.mozilla.org/mozilla-central/rev/aeaa4920fd59
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.