HomePanelDelegate needs to be able to optionally open pages in a new tab

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: st3fan, Unassigned)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(fxios-)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
We currently have:

protocol HomePanelDelegate: class {
    func homePanel(homePanel: HomePanel, didSelectURL url: NSURL)
}

Which opens the specified url in the frontmost tab. But often, like for the reading list panel, we want to open in a new tab. So I think we need this:

protocol HomePanelDelegate: class {
    func homePanel(homePanel: HomePanel, didSelectURL url: NSURL, inNewTab: Bool = false)
}

Updated

3 years ago
tracking-fxios: --- → ?
tracking-fxios: ? → -

Comment 1

3 years ago
Created attachment 8681908 [details] [review]
Pull request
Attachment #8681908 - Flags: review?(sarentz)
(Reporter)

Comment 2

3 years ago
hennes, i would like to keep this PR open until we have a use case for opening things in new tabs. I'm going to remove the review flag, but keep the PR open.
(Reporter)

Updated

3 years ago
Attachment #8681908 - Flags: review?(sarentz)

Comment 3

3 years ago
Sure, sounds good. Let me know if/when anything else is needed here.
As ActivityStream is replacing the home panels soon. We will be adding the functionality there instead.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.