Fix nsEscape.cpp compilation on mingw GCC 4.8.

RESOLVED FIXED in Firefox 39

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla39
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8576730 [details] [diff] [review]
fix

I've got a report from Michael Cronenworth:

In the process of updating Fedora for the new wine-gecko release I ran across an issue with the older gcc in Fedora 20. Fedora 20 uses gcc 4.8 while newer Fedoras use gcc 4.9+. There was a change in the typedef of char_type that results in a conversion failure on gcc 4.8.

It seems that GCC 4.8 can't handle templates in thiscase, because they require one more implicit cast (due to tricky char16ptr_t type). Being explicit about template type fixes the problem.
Attachment #8576730 - Flags: review?(nfroyd)
Attachment #8576730 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/c4a67c331727
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.