1142647 - [testdroid-proxy] Created signed URL for private build url without needing taskcluster-proxy

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Greg Arndt [:garndt]]

instead of relying on taskcluster-proxy returning a signed url (and possibly exposing it in the logs), have testdroid-proxy create it when requesting a new device (which is not exposed in the logs).

Comment 1

[Greg Arndt [:garndt]]

Attachment: GH PR 3

Here is a run using only testdroid-proxy and not the taskcluster-proxy http://docs.taskcluster.net/tools/task-inspector/#dYZlK50PSdO80VeCszg5IA/0

Comment 2

[Greg Arndt [:garndt]]

Attachment: docker-worker pass creds

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 8576805 [details]
GH PR 3

lgtm I think this is cleaner

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 8577043 [details] [review]
docker-worker pass creds

++

Comment 5

[Greg Arndt [:garndt]]

Comment on attachment 8577043 [details] [review]
docker-worker pass creds

Merged: https://github.com/taskcluster/docker-worker/commit/a149969bc2cca5235b0577e4a100f4883224812b

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8576805 [details]
GH PR 3

Merged: https://github.com/taskcluster/testdroid-proxy/commit/34fb523274b6bd209cb77a1249ac5d3661f36d71

Comment 7

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...