1142695 - Consider making Mutex, OffTheBooksMutex, BlockingResourceBase's dtors virtual

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

Coverity indicated a potential leak if an upcast pointer from a Mutex is deleted, Mutex's dtor would not be hit, ie something like:

> void killer(OffTheBooksMutex* b) { delete b; }
> Mutex* a = new Mutex("test");
> killer(a);

While it doesn't appear that this is currently happening (the instance Coverity flagged looks like a bug in Coverity), it certainly *could*.

Comment 1

[Benjamin Smedberg]

Since these classes don't have virtual methods currently, I really don't think we should pay the vtable penalty for this.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Benjamin Smedberg from comment #1)
> Since these classes don't have virtual methods currently, I really don't
> think we should pay the vtable penalty for this.

Yup.