Closed Bug 1142716 Opened 5 years ago Closed 5 years ago

update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP| and |mbuf|

Categories

(Toolkit :: Application Update, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: erahm, Assigned: robert.strong.bugs)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1286183][CID 1286097])

Attachments

(1 file)

Note: this is in test code.

CheckMsg leaks |inFP| [1] in various early exits.

[1] https://hg.mozilla.org/mozilla-central/annotate/0190a1d17294/toolkit/mozapps/update/tests/TestAUSHelper.cpp
Eric, this is a binary only used by tests and hence won't help the memshrink goals as I understand them from the memshrink page.
"MemShrink is a project that aims to reduce the memory consumption of Firefox (on desktop and mobile) and Firefox OS."
https://wiki.mozilla.org/Performance/MemShrink

I'm fine with this being fixed but this code is in no way tied to any application that we ship.

Can you provide details how this helps memshrink? Thanks!
Flags: needinfo?(erahm)
Summary: TestAUSHelper.cpp CheckMsg leaks |inFP| → update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP|
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> Can you provide details how this helps memshrink? Thanks!

I'm currently doing a coverity triage, I'm flagging anything showing up as a resource leak is being memshrink. Generally we'd make the decision whether or not a memshrink tag is appropriate in the bi-weekly memshrink triage.

But in this case it sounds like it's fine to clear.
Flags: needinfo?(erahm)
Whiteboard: [MemShrink][CID 1286183] → [CID 1286183]
It looks like |mbuf| [1] is also leaked.

[1] https://hg.mozilla.org/mozilla-central/annotate/0190a1d17294/toolkit/mozapps/update/tests/TestAUSHelper.cpp#l105
Summary: update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP| → update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP| and |mbuf|
Whiteboard: [CID 1286183] → [CID 1286183][CID 1286097]
Attached patch patchSplinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8577672 - Flags: review?(netzen)
Attachment #8577672 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/db07f0b48a2d
Flags: in-testsuite+
Target Milestone: --- → mozilla39
https://hg.mozilla.org/mozilla-central/rev/db07f0b48a2d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.