1142716 - update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP| and |mbuf|

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Eric Rahm [:erahm]]

Note: this is in test code.

CheckMsg leaks |inFP| [1] in various early exits.

[1] https://hg.mozilla.org/mozilla-central/annotate/0190a1d17294/toolkit/mozapps/update/tests/TestAUSHelper.cpp

Comment 1

[Robert Strong (they/them - no direct email)]

Eric, this is a binary only used by tests and hence won't help the memshrink goals as I understand them from the memshrink page.
"MemShrink is a project that aims to reduce the memory consumption of Firefox (on desktop and mobile) and Firefox OS."
https://wiki.mozilla.org/Performance/MemShrink

I'm fine with this being fixed but this code is in no way tied to any application that we ship.

Can you provide details how this helps memshrink? Thanks!

Comment 2

[Eric Rahm [:erahm]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> Can you provide details how this helps memshrink? Thanks!

I'm currently doing a coverity triage, I'm flagging anything showing up as a resource leak is being memshrink. Generally we'd make the decision whether or not a memshrink tag is appropriate in the bi-weekly memshrink triage.

But in this case it sounds like it's fine to clear.

Comment 3

[Eric Rahm [:erahm]]

It looks like |mbuf| [1] is also leaked.

[1] https://hg.mozilla.org/mozilla-central/annotate/0190a1d17294/toolkit/mozapps/update/tests/TestAUSHelper.cpp#l105

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/db07f0b48a2d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/db07f0b48a2d