Show client cert ID in WiFi auth dialog

RESOLVED WONTFIX

Status

()

Firefox
Developer Tools: WebIDE
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Blocks: 1027454
WebIDE's client auth dialog does not show the client cert ID for visual verification, but probably should.
Created attachment 8576959 [details]
MozReview Request: bz://1142730/jryans

/r/5273 - Bug 1142730 - Show client cert in WebIDE auth dialog. r=past

Pull down this commit:

hg pull review -r b751a240cdf13388e1ad8bcd3aaf52f8d598450a
Attachment #8576959 - Flags: review?(past)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5963022deea7
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8576959 [details]
MozReview Request: bz://1142730/jryans

https://reviewboard.mozilla.org/r/5271/#review4293

Ship It!
Attachment #8576959 - Flags: review?(past) → review+
Attempting fresh try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=123512453bf2
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/eb0a4ef7d8b9
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eb0a4ef7d8b9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
In bug 1032128, we determined the cert fingerprint adds visual noise to UX, especially since you're not meant to compare it visually, as you're required to scan the QR code, which preforms this work for you.

I'll revert this change.
Backed out:

https://hg.mozilla.org/integration/fx-team/rev/890e93b28bd0
Resolution: FIXED → WONTFIX
Comment on attachment 8576959 [details]
MozReview Request: bz://1142730/jryans
Attachment #8576959 - Attachment is obsolete: true
Attachment #8619742 - Flags: review+
Created attachment 8619742 [details]
MozReview Request: Bug 1142730 - Show client cert in WebIDE auth dialog. r=past
You need to log in before you can comment on or make changes to this bug.