Protocol error (unknownError): Error: Cannot call drainAllocationsLog without setting trackingAllocationSites to true

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Posted patch v1 (obsolete) — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8576964 - Flags: review?(jsantell)
This fixes the failures on my machine. Not 100% sure why though.
Attachment #8576964 - Flags: review?(jsantell) → review+
Keywords: leave-open
As expected, that didn't fix gum.
https://hg.mozilla.org/mozilla-central/rev/6c16de2f0bbf
Flags: in-testsuite+
Whiteboard: [fixed-in-fx-team]
Attachment #8576964 - Attachment is obsolete: true
Posted patch v1Splinter Review
wow
Attachment #8577504 - Flags: review?(jsantell)
Comment on attachment 8577504 [details] [diff] [review]
v1

Review of attachment 8577504 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/front.js
@@ +383,3 @@
>      let isDetached = (yield this._request("memory", "getState")) !== "attached";
>      if (isDetached) {
>        return;

Should probably deferred.resolve() here
Attachment #8577504 - Flags: review?(jsantell) → review+
Comment on attachment 8577504 [details] [diff] [review]
v1

Review of attachment 8577504 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/front.js
@@ +383,3 @@
>      let isDetached = (yield this._request("memory", "getState")) !== "attached";
>      if (isDetached) {
>        return;

Task.async returns a resolved promise anyway, no difference
Fixed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.