1142748 - Protocol error (unknownError): Error: Cannot call drainAllocationsLog without setting trackingAllocationSites to true

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

This fixes the failures on my machine. Not 100% sure why though.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/6c16de2f0bbf

Comment 4

[Victor Porof [:vporof][:vp]]

As expected, that didn't fix gum.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c16de2f0bbf

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1

wow

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8577504 [details] [diff] [review]
v1

Review of attachment 8577504 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/front.js
@@ +383,3 @@
>      let isDetached = (yield this._request("memory", "getState")) !== "attached";
>      if (isDetached) {
>        return;

Should probably deferred.resolve() here

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8577504 [details] [diff] [review]
v1

Review of attachment 8577504 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/front.js
@@ +383,3 @@
>      let isDetached = (yield this._request("memory", "getState")) !== "attached";
>      if (isDetached) {
>        return;

Task.async returns a resolved promise anyway, no difference

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/092e01b0561f

Comment 10

[Victor Porof [:vporof][:vp]]

Fixed