114275 - SVG build patches

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Bradley Baetz (:bbaetz)]

cls: I'm going to attach the SVG build patches for review. This only covers
changes to existing files (and the .m4 file brought in by configure), since
those are the only parts requiring review.

Libart is, as requested by staff@m.o, a separate, explicit option, because its
LGPL. We can use the system lib on unix, but we had to add a new api which
hasn't filtered upstream yet, so that part is commented out.

Assuming that you have no problems with this, then I'll announce the extra
changes to npm.{builds,svg,seamonkey}. Can I get you to add the extra option to
the .mozconfigs of the tinderboxes which build svg? You can add it now, since it
won't matter till this is committed (hopefully monday evening or Tue morning).

(mk_add_options MOZ_INTERNAL_LIBART_LGPL=1
MOZ_INTERNAL_LIBART_LGPL=1)

The affected tinderboxes appear to be: shrike, bismark, cement, monkeypox,
nebrios, otaku, palermo, and torino.

cls appears to own all of these except for palermo and torino, which look like
they're antitux's.

Note that the mac patches have not been tested - james' diff was truncated, so I
had to apply it by hand, and add the checkout line.

The .mcp files aren't included, although they have been committed on the
SVG_20010721_BRANCH. If this lands after the mac build system change, then I
presume that theres a simple conversion script to run, or something.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: SVG build patches

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: autoconf.mk.in patch I accidentally left off

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 60983 [details] [diff] [review]
SVG build patches

r=cls

Comment 4

[Bradley Baetz (:bbaetz)]

Attachment: client.mk/client.mak diffs

Grr. I know I diffed these. No idea what happened to them, though.

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 61030 [details] [diff] [review]
client.mk/client.mak diffs

r=cls
Tinderbox mozconfigs have been updated.

Comment 6

[Bradley Baetz (:bbaetz)]

This has now been checked in along with the rest of the SVG stuff.