Open Bug 1142776 Opened 5 years ago Updated 2 years ago

webrtc::FileAudioDevice leaks CriticalSection

Categories

(Core :: WebRTC: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

Blocking Flags:
backlog parking-lot

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [MemShrink:P3][CID 1274480])

|CriticalSection& FileAudioDevice::_critSection| is assigned a reference to an anonymously allocated CriticalSectionWrapper [1] which is then leaked upon destruction as it only holds a ref.

[1] https://hg.mozilla.org/mozilla-central/annotate/0190a1d17294/media/webrtc/trunk/webrtc/modules/audio_device/dummy/file_audio_device.cc#l34

I believe this problem exists upstream: https://code.google.com/p/webrtc/source/browse/trunk/webrtc/modules/audio_device/dummy/file_audio_device.cc?r=8691#34
Likely so.  THe code is compiled in, but we don't use it (and there's no way to invoke it I believe)
Flags: firefox-backlog-
Whiteboard: [MemShrink][CID 1274480] → [MemShrink:P3][CID 1274480]
backlog: --- → parking-lot
You need to log in before you can comment on or make changes to this bug.