Preliminary clean-ups for NativeDefineProperty work

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

unspecified
mozilla39
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
I am going to be knocking the stuffing out of NativeDefineProperty real soon now in bug 1125624. Here are some easy first steps.
(Assignee)

Comment 1

3 years ago
Created attachment 8576968 [details] [diff] [review]
part 1 - In NativeObject.cpp, move some Lookup functions out of the way and make a big swath of this file the [[DefineOwnProperty]] section
Attachment #8576968 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 2

3 years ago
Created attachment 8576978 [details] [diff] [review]
part 2 - Change ProxyHandler::defineProperty() to make the desc argument a non-mutable handle
Attachment #8576978 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

3 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8576986 [details] [diff] [review]
part 3 - Change js::DefinePropertyOp and a few property-defining functions to use PropertyDescriptor rather than separate (value, attrs, getter, setter) arguments
Attachment #8576986 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 4

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=244ad01effc4
Blocks: 1125624
(Assignee)

Comment 5

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=65363dd78d7a
Attachment #8576978 - Flags: review?(jwalden+bmo) → review+
Attachment #8576986 - Flags: review?(jwalden+bmo) → review+
Attachment #8576968 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/034f9c8e79ee
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd0af73ac84
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f0cb31263d
Backed out that whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/c3638d994edd for massive widespread bustage, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7613fc978d36&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception - something must have changed out from under you.
(Assignee)

Comment 8

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=b5371dadf35d
(Assignee)

Comment 9

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=06e71765256d
(Assignee)

Comment 10

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=5f219aeb17c7
(Assignee)

Comment 11

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=4981a11b0a15
(Assignee)

Comment 12

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=959a56f9f8c8
(Assignee)

Comment 13

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=0d7e5b7faf84
(Assignee)

Comment 14

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=7d43fd0109fd
(Assignee)

Comment 15

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=b9f6e59f7014
(Assignee)

Comment 16

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=39321d2999dc
(Assignee)

Comment 17

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=37bcfbecc724
(Assignee)

Comment 18

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=4fb215526977
(Assignee)

Comment 19

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3feda0f90a1f
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eca62492333
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8cf2a03ddcf
https://hg.mozilla.org/mozilla-central/rev/3feda0f90a1f
https://hg.mozilla.org/mozilla-central/rev/7eca62492333
https://hg.mozilla.org/mozilla-central/rev/c8cf2a03ddcf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.